Skip to content

Refactoring example #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2018
Merged

Refactoring example #367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b905bf
Refactoring example
hrchu May 7, 2018
09b4d49
Fix flake8 complain
hrchu May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def print_assignment(consumer, partitions):
# End of partition event
sys.stderr.write('%% %s [%d] reached end at offset %d\n' %
(msg.topic(), msg.partition(), msg.offset()))
elif msg.error():
else:
# Error
raise KafkaException(msg.error())
else:
Expand All @@ -113,5 +113,6 @@ def print_assignment(consumer, partitions):
except KeyboardInterrupt:
sys.stderr.write('%% Aborted by user\n')

# Close down consumer to commit final offsets.
c.close()
finally:
# Close down consumer to commit final offsets.
c.close()