-
Notifications
You must be signed in to change notification settings - Fork 915
Add basic OAuth support to Schema Registry #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- requirements/requirements-schemaregistry.txt: Language not supported
Comments suppressed due to low confidence (1)
src/confluent_kafka/schema_registry/error.py:64
- [nitpick] The error message format in
OAuthTokenError
could be more consistent and clear. Consider rephrasing to 'OAuthTokenError: {message} (HTTP status code: {status_code}, response: {response_text})'.
super().__init__(f"{message} (HTTP {status_code}): {response_text}")
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Claimundefine , left some initial comments
d20a8c6
to
f97a9ac
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed some minor typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Claimundefine , LGTM
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups