Skip to content

Add basic OAuth support to Schema Registry #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 22, 2025
Merged

Add basic OAuth support to Schema Registry #1919

merged 9 commits into from
Feb 22, 2025

Conversation

Claimundefine
Copy link
Contributor

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

2 similar comments
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@Claimundefine Claimundefine marked this pull request as ready for review February 13, 2025 19:57
@Copilot Copilot AI review requested due to automatic review settings February 13, 2025 19:57
@Claimundefine Claimundefine requested review from a team as code owners February 13, 2025 19:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • requirements/requirements-schemaregistry.txt: Language not supported
Comments suppressed due to low confidence (1)

src/confluent_kafka/schema_registry/error.py:64

  • [nitpick] The error message format in OAuthTokenError could be more consistent and clear. Consider rephrasing to 'OAuthTokenError: {message} (HTTP status code: {status_code}, response: {response_text})'.
super().__init__(f"{message} (HTTP {status_code}): {response_text}")

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Claimundefine , left some initial comments

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some minor typos

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Claimundefine , LGTM

@sonarqube-confluent
Copy link

Passed

Analysis Details

9 Issues

  • Bug 0 Bugs
  • Vulnerability 1 Vulnerability
  • Code Smell 8 Code Smells

Coverage and Duplications

  • Coverage 83.80% Coverage (61.70% Estimated after merge)
  • Duplications No duplication information (0.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

@Claimundefine Claimundefine merged commit 4a3694b into master Feb 22, 2025
2 checks passed
@Claimundefine Claimundefine deleted the sr_oauth branch February 22, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants