Skip to content

Replaced stale pull #785; add config bool return_record_name #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Replaced stale pull #785; add config bool return_record_name #1028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d3f90
Replaced stale pull #785; add config bool return_record_name
slominskir Feb 4, 2021
b07cfdf
Merge branch 'master' into return_record_name
Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/confluent_kafka/schema_registry/avro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,15 +259,19 @@ class AvroDeserializer(Deserializer):
from_dict (callable, optional): Callable(dict, SerializationContext) -> object.
Converts dict to an instance of some object.

return_record_name (bool): If True, when reading a union of records, the result will
be a tuple where the first value is the name of the record and the second value is
the record itself. Defaults to False.

See Also:
`Apache Avro Schema Declaration <https://avro.apache.org/docs/current/spec.html#schemas>`_

`Apache Avro Schema Resolution <https://avro.apache.org/docs/1.8.2/spec.html#Schema+Resolution>`_

"""
__slots__ = ['_reader_schema', '_registry', '_from_dict', '_writer_schemas']
__slots__ = ['_reader_schema', '_registry', '_from_dict', '_writer_schemas', '_return_record_name']

def __init__(self, schema_registry_client, schema_str=None, from_dict=None):
def __init__(self, schema_registry_client, schema_str=None, from_dict=None, return_record_name=False):
self._registry = schema_registry_client
self._writer_schemas = {}

Expand All @@ -278,6 +282,10 @@ def __init__(self, schema_registry_client, schema_str=None, from_dict=None):
" from_dict(SerializationContext, dict) -> object")
self._from_dict = from_dict

self._return_record_name = return_record_name
if not isinstance(self._return_record_name, bool):
raise ValueError("return_record_name must be a boolean value")

def __call__(self, value, ctx):
"""
Decodes a Confluent Schema Registry formatted Avro bytes to an object.
Expand Down Expand Up @@ -321,7 +329,8 @@ def __call__(self, value, ctx):

obj_dict = schemaless_reader(payload,
writer_schema,
self._reader_schema)
self._reader_schema,
self._return_record_name)

if self._from_dict is not None:
return self._from_dict(obj_dict, ctx)
Expand Down