Make reader schema optional in AvroDeserializer #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @97nitt just signed our Contributor License Agreement. 👍 Always at your service, clabot |
mhowlett
approved these changes
Mar 10, 2021
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created in response to the following issue:
#834
It makes the reader schema optional in
AvroDeserializer. When it is not provided, the writer schema is used for deserialization. Tests were updated to verify the deserializer works both with and without a reader schema.NOTE: this PR introduces breaking changes in both the
AvroSerializerandAvroDeserializer. The order of constructor arguments forAvroDeserializerhad to changed to accommodate the now optionalschema_strargument. I reordered the constructor arguments forAvroSerializerjust for consistency between the two classes.