Skip to content

Handle relative names in Protobuf registry#462

Merged
Robert Yokota (rayokota) merged 4 commits intomasterfrom
fix-relative-proto
Mar 4, 2026
Merged

Handle relative names in Protobuf registry#462
Robert Yokota (rayokota) merged 4 commits intomasterfrom
fix-relative-proto

Conversation

@rayokota
Copy link
Copy Markdown
Member

@rayokota Robert Yokota (rayokota) commented Feb 28, 2026

What

Handle relative names in Protobuf registry. Fixes #455

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

Copilot AI review requested due to automatic review settings February 28, 2026 02:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for deserializing Protobuf schemas whose FileDescriptorProto contains relative (non-fully-qualified) type_name references by normalizing them before building the Buf FileRegistry.

Changes:

  • Normalize relative FieldDescriptorProto.typeName values in FileDescriptorProto prior to calling createFileRegistry().
  • Apply the same normalization to dependency FileDescriptorProtos during resolution.
  • Add a Jest test that reproduces the relative typeName deserialization failure and asserts correct decoding.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
schemaregistry/serde/protobuf.ts Normalizes relative Protobuf typeName references before registry creation (including dependencies).
schemaregistry/test/serde/protobuf.spec.ts Adds a regression test for deserializing schemas with relative typeName values in a serialized descriptor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqube-confluent
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@tobiogunbi Tobi Ogunbi (tobiogunbi) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rayokota Robert Yokota (rayokota) merged commit 33c52ee into master Mar 4, 2026
3 checks passed
@rayokota Robert Yokota (rayokota) deleted the fix-relative-proto branch March 4, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProtobufDeserializer fails with type_name ... not found for file-level enums

3 participants