Handle relative names in Protobuf registry#462
Handle relative names in Protobuf registry#462Robert Yokota (rayokota) merged 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for deserializing Protobuf schemas whose FileDescriptorProto contains relative (non-fully-qualified) type_name references by normalizing them before building the Buf FileRegistry.
Changes:
- Normalize relative
FieldDescriptorProto.typeNamevalues inFileDescriptorProtoprior to callingcreateFileRegistry(). - Apply the same normalization to dependency
FileDescriptorProtos during resolution. - Add a Jest test that reproduces the relative
typeNamedeserialization failure and asserts correct decoding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
schemaregistry/serde/protobuf.ts |
Normalizes relative Protobuf typeName references before registry creation (including dependencies). |
schemaregistry/test/serde/protobuf.spec.ts |
Adds a regression test for deserializing schemas with relative typeName values in a serialized descriptor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7c161b6 to
4cd841a
Compare
|




What
Handle relative names in Protobuf registry. Fixes #455
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups