Skip to content

[APIE-416] Add new output field for tableflow topics #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgagniere
Copy link
Member

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • Add "Table Path" output field for confluent tableflow topic commands

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

For Confluent Cloud.

Update the confluent tableflow topic output to include the read-only "Table Path" ("table_path" for yaml/json) field.

TODO: Update the public SDK and remove the replace directive.

Blast Radius

None, this is an additive output change.

References

Test & Review

https://docs.google.com/document/d/1g8U3gpHc6sPN1aT396mLA6iqebNl5xqvDznHy7MpcAA/edit?usp=sharing

@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 00:31
@sgagniere sgagniere requested a review from a team as a code owner May 29, 2025 00:31
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new read-only "Table Path" output field for the confluent tableflow topic commands, updating both the command output and corresponding fixtures.

  • Added code paths to set and retrieve the Table Path for managed storage topics.
  • Updated golden files for topic list, describe, and create commands to include the Table Path field.
  • Modified the CLI output structures and update command logic to support the new field.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

File Description
test/test-server/tableflow_handlers.go Sets TablePath for managed storage while leaving it empty for BYOB.
test/fixtures/output/tableflow/topic/*.golden Updated expected outputs to include the Table Path field.
internal/tableflow/command_topic_list.go & command_topic.go Retrieves and outputs the TablePath value for managed and BYOB topics.
go.mod Updated replace directive for the SDK version.

@@ -12,5 +12,6 @@
| Bucket Region | us-east-1 |
| Suspended | false |
| Table Formats | ICEBERG |
| Table Path | |
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BYOB topics, the Table Path field is intentionally left empty. Consider adding a comment in the fixture or related test documentation to clarify that an empty Table Path is expected for these topics.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant