Skip to content

[APIE-24] Add support for CP Flink SQL Shell (WIP) #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

channingdong
Copy link
Contributor

@channingdong channingdong commented May 27, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Blast Radius

References

CP Flink SQL Shell Setup:
https://confluent.slack.com/archives/C078W406JQN/p1748430281177909

How to run CP Docker Image:
https://confluentinc.atlassian.net/wiki/spaces/~7120200093b08d224f47afa6c9f99df824f505/pages/4392780091/How+to+run+the+CP+Flink+Docker+Images

Test & Review

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 06:51
@channingdong channingdong requested a review from a team as a code owner May 27, 2025 06:51
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Confluent Platform (on-prem) support for Flink compute pools and catalogs, refactors command registration to branch on cloud vs on-prem login, and streamlines web UI forwarding logic.

  • Introduce on-prem create/describe/delete commands for Flink compute pools
  • Refactor newComputePoolCommand to register cloud or on-prem subcommands based on cfg.IsCloudLogin()
  • Add catalog commands and centralize Flink web UI forwarding via a new handler

Reviewed Changes

Copilot reviewed 60 out of 60 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/flink/command_compute_pool_create_onprem.go New on-prem compute-pool create command and output formatting
internal/flink/command_compute_pool.go Refactored newComputePoolCommand to take cfg and branch logic
internal/flink/command.go Reordered root commands, added catalog, compute-pool, shell, etc.
go.mod Added a local replace directive for development
internal/flink/command_application_list.go Updated application list logic to parse and validate job status
Comments suppressed due to low confidence (2)

internal/flink/command_application_list.go:52

  • [nitpick] This error message is repetitive and may confuse users. Consider rephrasing to something like "missing jobStatus field in application status", or include the application name for context.
return fmt.Errorf("job status not found in flink job status")

go.mod:286

  • This local filesystem replace directive should not be committed. Remove or convert it to a replace pointing at a versioned module reference to avoid breaking CI and other developers' builds.
replace github.com/confluentinc/cmf-sdk-go => /Users/channingdong/cmf-sdk-go

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Failed

  • 11.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 6 Code Smells

Coverage and Duplications

  • Coverage 11.70% Coverage (76.60% Estimated after merge)
  • Duplications No duplication information (0.10% Estimated after merge)

Project ID: cli

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants