-
Notifications
You must be signed in to change notification settings - Fork 18
Implement Upgrade Suggestions for Kafka Cluster Creation in the Confluent CLI #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…cluster and upgrading stream governance of an environment from essentials to advanced.
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- internal/kafka/upgrade_suggestions.json: Language not supported
return nil | ||
} | ||
|
||
copyManager, err := NewCopyManager() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider logging or handling the error from NewCopyManager instead of silently returning nil, so that issues with loading upgrade suggestions can be diagnosed.
Copilot uses AI. Check for mistakes.
return nil | ||
} | ||
|
||
content, cta, err := copyManager.GetCopy("cluster_upgrade_basic_to_standard") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider logging or handling the error from GetCopy rather than returning nil, which will help in troubleshooting if the upgrade suggestion copy fails to load.
Copilot uses AI. Check for mistakes.
Curious as to how acceptance testing works for this kind of scenario where you're doing an A/B test (some percent of orgs will see a certain output in the CLI vs. others) |
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
What
section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Review
section below.Blast Radius
section below.What
Added a feature-flagged upgrade suggestion that appears after creating a Basic Kafka cluster, encouraging users to upgrade to Standard. The suggestion is shown to 85% of organizations and includes specific limitations of Basic clusters with a direct upgrade command.
Blast Radius
If the feature flag service is unavailable or the upgrade suggestion fails, users will simply not see the suggestion message. No core functionality is affected - users can still create and use their clusters normally.
References
https://confluentinc.atlassian.net/browse/CLI-3502
https://app.launchdarkly.com/projects/cli/flags/cli.basic-to-standard-cluster-upgrade-suggestion/targeting?env=production&env=test&selected-env=production
Test & Review
Feature flag ON:

Feature flag OFF:
