Skip to content

Implement Upgrade Suggestions for Kafka Cluster Creation in the Confluent CLI #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

danielayaz
Copy link
Member

@danielayaz danielayaz commented Apr 8, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Added a feature-flagged upgrade suggestion that appears after creating a Basic Kafka cluster, encouraging users to upgrade to Standard. The suggestion is shown to 85% of organizations and includes specific limitations of Basic clusters with a direct upgrade command.

Blast Radius

If the feature flag service is unavailable or the upgrade suggestion fails, users will simply not see the suggestion message. No core functionality is affected - users can still create and use their clusters normally.

References

https://confluentinc.atlassian.net/browse/CLI-3502
https://app.launchdarkly.com/projects/cli/flags/cli.basic-to-standard-cluster-upgrade-suggestion/targeting?env=production&env=test&selected-env=production

Test & Review

Feature flag ON:
image

Feature flag OFF:
image

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@danielayaz danielayaz marked this pull request as ready for review April 8, 2025 19:45
@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 19:45
@danielayaz danielayaz requested a review from a team as a code owner April 8, 2025 19:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • internal/kafka/upgrade_suggestions.json: Language not supported

return nil
}

copyManager, err := NewCopyManager()
Copy link
Preview

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider logging or handling the error from NewCopyManager instead of silently returning nil, so that issues with loading upgrade suggestions can be diagnosed.

Copilot uses AI. Check for mistakes.

return nil
}

content, cta, err := copyManager.GetCopy("cluster_upgrade_basic_to_standard")
Copy link
Preview

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider logging or handling the error from GetCopy rather than returning nil, which will help in troubleshooting if the upgrade suggestion copy fails to load.

Copilot uses AI. Check for mistakes.

@danielayaz
Copy link
Member Author

Curious as to how acceptance testing works for this kind of scenario where you're doing an A/B test (some percent of orgs will see a certain output in the CLI vs. others)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant