-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config v6 #96
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 91.69% 92.70% +1.00%
==========================================
Files 18 20 +2
Lines 1626 2069 +443
Branches 412 560 +148
==========================================
+ Hits 1491 1918 +427
- Misses 134 150 +16
Partials 1 1 ☔ View full report in Codecov by Sentry. |
96f6570
to
9cb76f9
Compare
…tral Unicode chars (U+10000 and above)
…s to User Object attribute values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
54f1237
to
b88db79
Compare
…tes if the case of number/date comparators
…valuationPercentageRule + tests
…called with invalid value
# Conflicts: # src/ConfigCatClientOptions.ts # test/ConfigCatClientTests.ts
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi! Could you advice how to use |
The Although this feature is already supported by the SDK, it's not available on the dashboard yet. However, if you are interested in Config V2, you can try it soon as the Beta Test is about to launch in the next weeks. For more details, please watch our news page or join this public slack channel. |
Implements config v6 support.
Features/improvements:
config_v6.json
) and update config modelIEvaluationDetails.matchedTargetingRule
/matchedPercentageOption
properties (rename + set combinations correctly)Tests:
Flag overrides vs. config json salt and segments(skipped as JS SDKs don't support full config json flag overrides)IEvaluationDetails.matchedTargetingRule
/matchedPercentageOption
properties (rename + set combinations correctly)Related improvements/fixes:
Dynamically typed languages should log a warning when default value doesn't match the setting type (see https://trello.com/c/Le6vimGu)(because of TS, we need to implement the behavior of statically typed languages)We should go to the cache in all polling modes instead of using the in memory variable (see https://trello.com/c/rreKm64A)(done earlier)Breaking changes:
matchedEvaluationRule
property tomatchedTargetingRule
and thematchedEvaluationPercentageRule
property tomatchedPercentageOption
inIEvaluationDetails
.IConfig
and related interfaces/enums).Requirement checklist (only if applicable)