pre-reqs: Update nydus snapshotter version #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump the nydus snapshotter version to v0.13.13, in order to pick the nydus-snapshotter caching workaround containerd/nydus-snapshotter#593 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
fidencio
approved these changes
May 15, 2024
ldoktor
reviewed
May 15, 2024
| @@ -13,7 +13,7 @@ official_containerd_version=${official_containerd_version:-"1.7.7"} | |||
| vfio_gpu_containerd_repo=${vfio_gpu_containerd_repo:-"https://github.com/confidential-containers/containerd"} | |||
| vfio_gpu_containerd_version=${vfio_gpu_containerd_version:-"1.7.0.0"} | |||
| nydus_snapshotter_repo=${nydus_snapshotter_repo:-"https://github.com/containerd/nydus-snapshotter"} | |||
| nydus_snapshotter_version=${nydus_snapshotter_version:-"v0.13.3-multiarch"} | |||
| nydus_snapshotter_version=${nydus_snapshotter_version:-"v0.13.13"} | |||
There was a problem hiding this comment.
is it necessary to keep updating the default when we have it specified in the Makefile? Having 2 places can be confusing...
There was a problem hiding this comment.
I agree with you, but didn't want to go into that on this PR. Do you thing an approach of us letting the set -o nounset fail if it's not passed in would make sense?
- To avoid having to update the versions in multiple places (which was missed last release), remove the default versions logic in payload.sh, as it is only called from the Makefile If a version is incorrectly set, then just rely on `set -o nounset` to warn the user about this Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
bump-nydus-snapshotter-3.13
branch
from
eb997e7
to
3cd1a12
Compare
mkulke
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapshot: fix error on proxy driver when switching different snapshotter containerd/nydus-snapshotter#593