Skip to content

Conversation

@IgorChvyrov-sm
Copy link
Contributor

@IgorChvyrov-sm IgorChvyrov-sm commented Oct 22, 2025

Changes:

Updated configuration to set None as default value for worker_domain
Updated tests to reflect default value change

Reason:
#348

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...ctor/asyncio_client/configuration/configuration.py 97.67% <ø> (-2.33%) ⬇️
...rc/conductor/client/configuration/configuration.py 89.91% <100.00%> (-0.31%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty clear, thanks

@IgorChvyrov-sm IgorChvyrov-sm merged commit c37dff1 into main Oct 27, 2025
2 checks passed
@nthmost-orkes nthmost-orkes deleted the fix_worker_domain_configuration branch October 28, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python SDK workers cannot pick up tasks from workflows created in UI without domain configuration

3 participants