-
Notifications
You must be signed in to change notification settings - Fork 37
Tags field for event handler #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s and moved shared enums
This reverts commit cb9fc88.
…s_field_for_event_handler
…s_field_for_event_handler
|
I wanted a moment to look at the different API parameter orders, so I had Claude generate the following. Just wanted to put this somewhere since "developer intuition" (let's call it) is something we don't currently value in our API design and I wish we did. If you wouldn't mind, @IgorChvyrov-sm could you add a few comments in the code just to acknowledge the asymmetry? Thanks. Technical Note: Sync vs Async API Signature AsymmetryDuring review, we identified that the sync and async event tag APIs have different parameter orders due to different code generation tools: Observed Behavior
Root CauseDifferent code generators:
Implementation in This PRThis PR correctly adapts to both signatures:
Both approaches are correct and will work as expected. Code comments have been added to help future maintainers understand this asymmetry. Future WorkConsider regenerating the sync client with updated tooling to align parameter orders across sync/async APIs (tracked separately as technical debt). Verified Against:
|
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my longer reply above -- I just want to put comments into the spots where we're having to use different parameter orders for what should really be totally symmetrical API calls.
|
Hi, @nthmost-orkes. I agree with your point about inconsistencies. Added a comment to highlight the inconsistency. Good catch, thank you! |
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great TY!
Changes:
Added Orkes Event Clients for sync and async sdk clients
Added integration tests