Repository navigation
fix(ui): show the cron expression column by default in the schedule list - #1686
Merged
Merged
Conversation
defaultShowColumns listed "cronTabExpression", but the column id is "cronExpression", so the column was hidden unless enabled manually. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 of 6 tasks
Contributor
|
can we add a test? |
Extract defaultShowColumns into getDefaultShowColumns() and assert every id it lists matches a real column, so a typo like "cronTabExpression" can't silently hide a column again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ajlai-orkes
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
The schedule list (Definitions → Scheduler,
/scheduleDef) hid the Cron Expression column by default.Schedules.tsxpassesdefaultShowColumnstoDataTable, which hides any column whose id isn't in that list (DataTable.tsx:166-168). The list contained"cronTabExpression", but the column id is"cronExpression". The column was only visible if a user turned it on under Columns.This PR changes the entry to
"cronExpression". The column now shows by default, first in the table, with the schedule in plain English (for example "Every hour").Users who have already customised their columns keep their saved layout, which is stored in local storage under
schedulesTable, so they won't see the change.Testing
I served the pre-fix and post-fix UI side by side against the same local server and loaded
/scheduleDefin fresh browser contexts with no saved layout:This change was split out of #1685 so each fix merges on its own.
Alternatives considered
None. This is a one-word fix to a mismatched column id.
🤖 Generated with Claude Code