Skip to content

https://orkes.atlassian.net/browse/CCOR-13360 - #1572

Merged
ajlai-orkes merged 2 commits into
mainfrom
fix/CCOR-13360
Aug 26, 2026
Merged

ajlai-orkes merged 2 commits into
mainfrom
fix/CCOR-13360

Conversation

@ajlai-orkes

Copy link
Copy Markdown
Contributor

Workflow diagram 'Export to image' has multiple issues (unresponsive, draft export fails, switch node unreadable)

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

  • Fixes workflow Export to image so SWITCH diamonds stay white with a readable border instead of rendering as a solid black shape. StarShape now paints an explicit fill and uses a CSS drop-shadow, because dom-to-image inlines computed styles onto its clone and a -inherited fill was being pinned to the initial value (black).
  • Makes exports that previously failed silently actually succeed. dom-to-image was writing SVG into a data: URI without fully encoding the payload, so a sequence like %3C was percent-decoded a second time into <, the SVG failed to load, and the library rejected with an empty image error event. The payload is now encodeURIComponent’d, matching html-to-image.
  • Shows an error toast when export still fails, with a useful reason instead of [object Event] / “check the console”.
  • Adds a Playwright check that clicks Export to image, waits for the download, and snapshots the PNG. The comparison is tight (maxDiffPixels: 200) so a black diamond (~1.4% of a 2400×1161 image) cannot hide under the suite’s 2% screenshot tolerance.
switch (1)

Workflow diagram 'Export to image' has multiple issues (unresponsive, draft export fails, switch node unreadable)
@ajlai-orkes
ajlai-orkes merged commit 1444b62 into main Aug 26, 2026
14 checks passed
@ajlai-orkes
ajlai-orkes deleted the fix/CCOR-13360 branch August 26, 2026 00:55
matteius pushed a commit to opensensor/conductor that referenced this pull request Sep 13, 2026
Workflow diagram 'Export to image' has multiple issues (unresponsive, draft export fails, switch node unreadable)

(cherry picked from commit 1444b62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants