Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ruamel.yaml usage to use supported APIs #5517

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Oct 25, 2024

Description

This PR moves the ruamel.yaml calls to the new APIs.

Fixes #5515

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 25, 2024
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #5517 will not alter performance

Comparing beckermr-patch-2 (afad36e) with main (ebaf9ed)

Summary

✅ 5 untouched benchmarks

@beckermr beckermr marked this pull request as ready for review October 25, 2024 12:01
@beckermr beckermr requested a review from a team as a code owner October 25, 2024 12:01
@beckermr beckermr changed the title fix: update pypi skeleton patch to use latest ruamel.yaml syntax fix: update ruamel.yaml usage to use supported APIs Oct 25, 2024
@beckermr
Copy link
Contributor Author

pre-commit.ci autofix

tests/test_api_skeleton.py Outdated Show resolved Hide resolved
tests/test_api_skeleton.py Outdated Show resolved Hide resolved
tests/test_api_skeleton.py Outdated Show resolved Hide resolved
@beckermr
Copy link
Contributor Author

@zooba @conda/builds-tools This PR is ready to go. The test failures are unrelated.

@beckermr beckermr enabled auto-merge (squash) October 25, 2024 15:42
@beckermr
Copy link
Contributor Author

Thanks @isuruf! Hopefully the unrelated flaky tests finally pass so this can get merged.

@beckermr beckermr merged commit 810be76 into main Oct 25, 2024
27 of 28 checks passed
@beckermr beckermr deleted the beckermr-patch-2 branch October 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

tests are busted due to something with setuptools and ruamel.yaml
3 participants