Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sys.exit in conda_build.build.bundle_conda #5367

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

kenodegard
Copy link
Contributor

Description

Replacing sys.exit call in bundle_conda with the new CondaBuildUserError exception for better downstream error handling. Add missing unit test.

Xref #4209

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner June 11, 2024 14:28
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 11, 2024
Copy link

codspeed-hq bot commented Jun 11, 2024

CodSpeed Performance Report

Merging #5367 will not alter performance

Comparing kenodegard:remove-sys.exit-bundle_conda (d416002) with main (bf79003)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard merged commit 3515dbe into conda:main Jun 11, 2024
30 checks passed
@kenodegard kenodegard deleted the remove-sys.exit-bundle_conda branch June 11, 2024 16:02
@beeankha beeankha mentioned this pull request Jul 16, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants