-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom chunk size for regex calls on Windows #5185
base: main
Are you sure you want to change the base?
Conversation
allow customization using env var to cover corner cases with many nested folders
We require contributors to sign our Contributor License Agreement and we don't have one on file for @adriendelsalle. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#877), and ping the bot to refresh the PR. |
@conda-bot check |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@dbast ping, is it possible to review this small PR? |
|
allow customization using env var to cover corner cases with many nested folders
Description
Fix build error on Windows, when paths are too long, or package contains too many files, by allowing users to set the chunk size for regex operation on Windows using environment variable
CONDA_BLD_REGEX_CHUNK_SIZE
.I don't know what's the best way to pass this configuration value.
Maybe we could also add a try/catch around the regex call to give a hint if it fails.
Fixes #5122
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?