-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SHA224, SHA384 and SHA512 source hashes. #4793
Open
tttc3
wants to merge
16
commits into
conda:main
Choose a base branch
from
tttc3:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Mar 5, 2023
10 tasks
varlackc
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
kenodegard
requested changes
Feb 26, 2024
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
kenodegard
reviewed
Feb 26, 2024
kenodegard
previously approved these changes
Feb 26, 2024
beeankha
previously approved these changes
Feb 27, 2024
CodSpeed Performance ReportMerging #4793 will not alter performanceComparing Summary
|
beeankha
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides support for validating source checksums via SHA224, SHA384 and SHA512, in addition to the existing MD5, SHA1 and SHA256 options. A similar request has been made for
boa
(see here).In addition, when multiple checksums are provided in the recipe, a
RuntimeError
will now be raised if any of the checksums are wrong. Previously, this error would not necessarily be raised if one of the provided checksums was valid (if this was an intentional design choice then this part can be reverted/excluded from the pull).Documentation and appropriate test-recipes have been updated to include examples of using the new checksums.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?