Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SHA224, SHA384 and SHA512 source hashes. #4793

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

tttc3
Copy link
Contributor

@tttc3 tttc3 commented Mar 5, 2023

Description

Provides support for validating source checksums via SHA224, SHA384 and SHA512, in addition to the existing MD5, SHA1 and SHA256 options. A similar request has been made for boa (see here).

In addition, when multiple checksums are provided in the recipe, a RuntimeError will now be raised if any of the checksums are wrong. Previously, this error would not necessarily be raised if one of the provided checksums was valid (if this was an intentional design choice then this part can be reverted/excluded from the pull).

Documentation and appropriate test-recipes have been updated to include examples of using the new checksums.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 5, 2023
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@tttc3 tttc3 requested a review from a team as a code owner February 22, 2024 18:56
conda_build/source.py Outdated Show resolved Hide resolved
conda_build/source.py Outdated Show resolved Hide resolved
news/4793-support-sha224-sha384-and-sha512 Outdated Show resolved Hide resolved
news/4793-support-sha224-sha384-and-sha512 Outdated Show resolved Hide resolved
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@kenodegard
Copy link
Contributor

pre-commit.ci autofix

conda_build/source.py Outdated Show resolved Hide resolved
kenodegard
kenodegard previously approved these changes Feb 26, 2024
beeankha
beeankha previously approved these changes Feb 27, 2024
@tttc3 tttc3 dismissed stale reviews from beeankha and kenodegard via 0466b8c April 21, 2024 14:15
Copy link

codspeed-hq bot commented Apr 21, 2024

CodSpeed Performance Report

Merging #4793 will not alter performance

Comparing tttc3:main (56303cc) with main (45be77d)

Summary

✅ 3 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

6 participants