Open
Description
openedon Dec 6, 2023
What happened?
GitHub is discontinuing SVN support: https://github.blog/2023-01-20-sunsetting-subversion-support/
This caused the tests/test_api_build.py::test_checkout_tool_as_dependency
test to start failing.
Fixing the failure started to uncover more issues than could be reasonably resolved while trying to get a hotfix out (see #5096), so for now the test has been marked as xfail until we have time to address all of the issues.
Discovery:
- I first tried to refactor the test to use Git instead of SVN, this worked for Linux/macOS but on Windows resulted in some perplexing cloning errors
- After digging some more it seems the cloning error comes from how git is invoked. Before cloning a git repo, we "detect" the git executable using
conda_build.os_utils.external.find_executable
which injects theroot_dir
(a.k.a.context.root_prefix
) paths ahead of everything onPATH
. IOW the build env is shadowed by the root env (SVN and Mercurial on the other hand do not do this detection and rather just runssvn
andhg
commands viasubprocess.Popen
and so the build env takes priority). - The special git executable detection done appears to be done in order to later pass the same executable to the patching logic? Not sure yet why this is necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Type
Projects
Status
🆕 New