Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial value outside of local. Fixes #42 #46

Merged

Conversation

hwalinga
Copy link
Contributor

@hwalinga hwalinga commented Nov 9, 2022

Old version of zsh cannot set initial value when declaring with local. Giving you all environment variables as a side effect. This change fixes that bug. This bug appears on zsh 5.0.2, as seen on CentOS 7, as previously reported.

Fixes #42

NB. My vim fixed some extra white space automatically. Hope you don't mind.

@hwalinga hwalinga changed the title Set initial value outside of local. Set initial value outside of local. Fixes #42 Nov 9, 2022
@esc
Copy link
Contributor

esc commented Feb 2, 2023

@jezdez can you look into reviewing this one?

@jezdez jezdez self-requested a review February 2, 2023 15:49
@coldfix
Copy link
Contributor

coldfix commented Nov 1, 2023

I've encountered the same issue on RHEL7 (zsh 5.0.2). Without this fix, the terminal is flodded with gobbledygook after conda activate + <tab>

@esc
Copy link
Contributor

esc commented Feb 27, 2024

I'm going to merge this speculatively based on user input, we can always revert or find an alternative if this breaks the completion for everyone else (which I highly doubt).

Thank you @hwalinga and @coldfix

@esc esc closed this Feb 27, 2024
@esc esc reopened this Feb 27, 2024
@esc esc merged commit 4fce479 into conda-incubator:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Conda activate' always completes with all environment variables
3 participants