Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused _internal/client module #928

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Oct 28, 2024

partially fixes #914

Description

This module isn't used by anything in conda-store-server. Being in the _internal package, they should also not be depended on by any external packages.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit f49b23a
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671fb0ddaf66d1000823256d

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted, I hadn't noticed this before 🚀

@peytondmurray peytondmurray merged commit 24ed0a4 into conda-incubator:main Oct 28, 2024
27 checks passed
@soapy1 soapy1 deleted the remove-unused-module branch October 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Improve testing - developer experience
2 participants