Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Extend compose to include target for local UI #905

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

trallard
Copy link
Collaborator

Description

There is no issue associated with this PR but this should help us with verifying how we are vendoring the UI (and the conda-store releases)

  • Adds a docker-compose.ui.yaml file that builds the dev-ui target in the Dockerfile
  • Adds a missing step in our release instructions

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

I will update the docs once someone else verifies this.

  1. You will need to have a local fork of conda-store-ui and create a bundle:

    yarn run build
    yarn run webpack:prod bundle
  2. On the conda-store repository:

    # change into the conda-store-server dir
    cd conda-store-server
    
    # build server with the local bundle of the UI
    export LOCAL_UI=<path-to-the-root-of-the-ui-dir>  && hatch build
  3. Start the conda-store-instances:

    # from the root of the conda-store repo
    docker compose -f docker-compose.ui.yaml up --build

    Head to localhost:8080 when ready, if built against main the version displayed on the UI should be "2024.9.2-rc1"

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 7492e49
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671676176797430008727021

@trallard trallard requested a review from soapy1 October 21, 2024 15:08
Copy link
Contributor

@soapy1 soapy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also verified the setup instructions work 👍

Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the steps in the PR description.

  • conda-store-ui: pulled latest main, built js files from typescript and created js bundle with webpack
  • conda-store: applied this PR, executed commands to copy local UI bundle into server folder, started up Docker, and loaded the UI

Since it worked, I'm approving this PR.

However, I feel like there's got to be a simpler way to do all of this.

@trallard
Copy link
Collaborator Author

Yep, I can move the hatch part to the Dockerfile or something to skip a couple of steps. But we can do that later, for now I needed a quick way to build against the UI.

Thanks both.

@trallard trallard merged commit 2104c45 into main Oct 22, 2024
27 checks passed
@trallard trallard deleted the trallard/update-bundling-docker branch October 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants