-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV - Extend compose to include target for local UI #905
Conversation
✅ Deploy Preview for conda-store canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I also verified the setup instructions work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the steps in the PR description.
- conda-store-ui: pulled latest main, built js files from typescript and created js bundle with webpack
- conda-store: applied this PR, executed commands to copy local UI bundle into server folder, started up Docker, and loaded the UI
Since it worked, I'm approving this PR.
However, I feel like there's got to be a simpler way to do all of this.
Yep, I can move the hatch part to the Dockerfile or something to skip a couple of steps. But we can do that later, for now I needed a quick way to build against the UI. Thanks both. |
Description
There is no issue associated with this PR but this should help us with verifying how we are vendoring the UI (and the conda-store releases)
docker-compose.ui.yaml
file that builds thedev-ui
target in the DockerfilePull request checklist
Additional information
I will update the docs once someone else verifies this.
You will need to have a local fork of
conda-store-ui
and create a bundle:On the
conda-store
repository:Start the conda-store-instances:
# from the root of the conda-store repo docker compose -f docker-compose.ui.yaml up --build
Head to localhost:8080 when ready, if built against main the version displayed on the UI should be
"2024.9.2-rc1"