Run linter on tests and docs #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
nkaretnikov
added
area: documentation 📖
|
@dcmcand PTAL. Let me know if you currently don't have cycles, then I'll assign someone else. |
trallard
approved these changes
Feb 27, 2024
|
|
||
| - repo: https://github.com/charliermarsh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: "v0.0.289" | ||
| hooks: | ||
| - id: ruff | ||
| exclude: "examples|tests|docs" |
There was a problem hiding this comment.
It annoys me a bit that we skip examples and the such as it breaks consistency but this might need a deeper look and follow up
There was a problem hiding this comment.
I skipped examples because they have config files, which by design use unbound variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768.
Description
This pull request changes the linter config to run on tests and docs.
Pull request checklist
Additional information
How to test