Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim conda-store package dependencies #1056

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 23, 2025

Fixes #1053

Description

The conda-store (cli) package does not have dependencies on jupyter - cleaning up these dependencies.

For reference, you can also check against the conda package recipe https://github.com/conda-incubator/conda-store/blob/main/recipe/meta.yaml#L34-L43 (which does not express any dependencies on jupyter).

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1 soapy1 requested a review from peytondmurray January 23, 2025 01:58
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 8c9aa1d
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6791a22b782bf70008c23d16

@trallard
Copy link
Collaborator

Looks good, but while you are it can you do a thorough check of all our deps in case there are others that should be removed or bumped?

@trallard trallard added area: dependencies 📦 Issues related to conda-store dependencies needs: review 👀 labels Jan 24, 2025
@soapy1
Copy link
Contributor Author

soapy1 commented Jan 24, 2025

can you do a thorough check of all our deps in case there are others that should be removed or bumped?

Yep, done. The pyproject.yoml and conda recipes are also now matching.

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's some automated tooling to check whether certain dependencies are used...

Anyway, looks good 🚀

@peytondmurray peytondmurray merged commit bcf9404 into conda-incubator:main Jan 24, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies needs: review 👀
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - conda-store pins very old (unused?) jupyterhub
3 participants