Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xarray v0.20.0 #67

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Nov 3, 2021

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1416305991, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • pyyaml
  • python-dateutil
  • conda
  • hypothesis
  • sparse
  • pytest

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jhamman
Copy link
Member

jhamman commented Nov 3, 2021

One thing to double check here, we have two Python 3.7 only dependencies that are not listed in the recipe here:

  • importlib_metadata (1.4 or later, Python 3.7 only)
  • typing_extensions (3.7 or later, Python 3.7 only)

There was a long discussion in pydata/xarray#5845 so surfacing here to make sure we get the right outcome for this release.

ping @keewis, @dopplershift, @marscher, and @Illviljan

@ocefpaf
Copy link
Member

ocefpaf commented Nov 3, 2021

@jhamman I need to check but I'm pretty sure we can maintain noarch and keep those installed across all Python versions. Where they exist in the standard library xarray will use it, where it doesn't, it will call the external module. This is a trick to keep things noarch and dependencies simple.

@marscher
Copy link

marscher commented Nov 3, 2021

I think it would be safest, if we just install importlib_metadata unconditionally for all Python versions. We can drop this requirement when Python-3.7 is out of service.

@dopplershift
Copy link
Member

I updated the dependencies to include importlib_metadata and typing_extensions >=3.7, as well as bumped numpy and pandas from upstream. Since I'm not listed as a maintainer, this should get a review from one of @shoyer @jhamman @ocefpaf .

@dopplershift dopplershift merged commit 65d1540 into conda-forge:master Nov 4, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.20.0_h19fab0 branch November 4, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants