Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import recipes from github.com/anguslees/conda-* #537

Closed
wants to merge 31 commits into from

Conversation

anguslees
Copy link

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/alembic, recipes/amqp, recipes/cliff, recipes/cmd2, recipes/debtcollector, recipes/eventlet, recipes/extras, recipes/fixtures, recipes/jsonpatch, recipes/jsonpointer, recipes/keystonemiddleware, recipes/kombu, recipes/librabbitmq, recipes/linecache2, recipes/monotonic, recipes/netaddr, recipes/netifaces, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.config, recipes/oslo.context, recipes/oslo.db, recipes/oslo.i18n, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/oslo.serialization, recipes/oslo.utils, recipes/pluggy, recipes/prettytable, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-mimeparse, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/retrying, recipes/rfc3986, recipes/sqlalchemy-migrate, recipes/stevedore, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/testtools, recipes/tox, recipes/traceback2, recipes/vcversioner, recipes/warlock, recipes/websockify) and found some lint.

Here's what I've got...

For recipes/cliff:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/eventlet:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/kombu:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/nova:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/oslo.config:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/python-cinderclient:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/python-glanceclient:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/python-keystoneclient:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/python-neutronclient:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/python-novaclient:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/stevedore:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

@anguslees
Copy link
Author

I piled everything into one PR because it was easier for me. Let me know if you would prefer one PR per recipe.

As per conda-forge-linter's suggestion.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/alembic, recipes/amqp, recipes/cliff, recipes/cmd2, recipes/debtcollector, recipes/eventlet, recipes/extras, recipes/fixtures, recipes/jsonpatch, recipes/jsonpointer, recipes/keystonemiddleware, recipes/kombu, recipes/librabbitmq, recipes/linecache2, recipes/monotonic, recipes/netaddr, recipes/netifaces, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.config, recipes/oslo.context, recipes/oslo.db, recipes/oslo.i18n, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/oslo.serialization, recipes/oslo.utils, recipes/pluggy, recipes/prettytable, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-mimeparse, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/retrying, recipes/rfc3986, recipes/sqlalchemy-migrate, recipes/stevedore, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/testtools, recipes/tox, recipes/traceback2, recipes/vcversioner, recipes/warlock, recipes/websockify) and found it was in an excellent condition.

@msarahan
Copy link
Member

msarahan commented May 4, 2016

Breaking things up would be nice. You don't have to go all the way to one recipe per PR, but please limit it to related recipes in each PR.

Otherwise, this will take forever to review, and might get lost.

Thanks for adding your recipes!

@jakirkham
Copy link
Member

So, some of these already exist so let's start by clearing those out first. Feel free to PR the feedstocks and add yourself as a maintainer on them.

@jakirkham
Copy link
Member

jakirkham commented May 4, 2016

Breaking things up would be nice. You don't have to go all the way to one recipe per PR, but please limit it to related recipes in each PR.

Otherwise, this will take forever to review, and might get lost.

I think I encouraged him to dump them in elsewhere. Though it's true. Review time is the biggest issue.

@jakirkham
Copy link
Member

Also, get rid of rabbitmq and try to join forces on this PR ( #471 ).

- six >=1.7.0
- decorator
- sqlparse
- tempita >-0.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be >=0.4?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes it should. None of the tools ever balked at that - I guess they were doing "greater than a negative number"?

@jakirkham
Copy link
Member

Some general thoughts on the recipes.

  • Licenses should be versioned (e.g. Apache 2.0, BSD 3-Clause, LGPL 2.1, etc.). Terse licenses are generally encouraged.
  • If it is a simple python install script just add setup.py install --single-version-externally-managed --record record.txt to build/script and eliminate build.sh and bld.bat.
  • Patches should be submitted upstream (they don't need to be accepted yet). Though do include a link to the upstream submission (e.g. PR for GitHub) and a brief summary in the meta.yaml about what the patch does and why we need it.

@jakirkham
Copy link
Member

Thanks for the submission, @anguslees. I have tried to make some general notes about things that we can leave out to make this PR a little more review friendly. There were also a few things that stood out that I commented on. From a brief skim, these appear to be pretty healthy recipes.

@anguslees
Copy link
Author

Sorry, I thought I had removed the duplicates, but must have messed up my conda search command somehow. I'll try that process again now I have some candidates that should be detected..

I'll break it up into smaller chunks too..

@jakirkham
Copy link
Member

Sorry, I thought I had removed the duplicates, but must have messed up my conda search command somehow. I'll try that process again now I have some candidates that should be detected..

No worries. I think those were the only ones. With the PR, it was named differently so not sure if you would have caught that.

I'll break it up into smaller chunks too..

Sure, but feel free to leave this here as you do. That way you can kind of keep a check list of what still needs to move.

@anguslees
Copy link
Author

rabbitmq (#471) is rabbitmq-server, librabbitmq is a (python) client and not a duplicate, fwiw.

@jakirkham
Copy link
Member

rabbitmq (#471) is rabbitmq-server, librabbitmq is a (python) client and not a duplicate, fwiw.

Sorry, was doing my best to skim 160 files. 😜

amqp, kombu, vcversioner are already on conda-forge at equal or newer
versions.
"tempita >-0.4" should have been ".. >=0.4"
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/alembic, recipes/cliff, recipes/cmd2, recipes/debtcollector, recipes/eventlet, recipes/extras, recipes/fixtures, recipes/jsonpatch, recipes/jsonpointer, recipes/keystonemiddleware, recipes/librabbitmq, recipes/linecache2, recipes/monotonic, recipes/netaddr, recipes/netifaces, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.config, recipes/oslo.context, recipes/oslo.db, recipes/oslo.i18n, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/oslo.serialization, recipes/oslo.utils, recipes/pluggy, recipes/prettytable, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-mimeparse, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/retrying, recipes/rfc3986, recipes/sqlalchemy-migrate, recipes/stevedore, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/testtools, recipes/tox, recipes/traceback2, recipes/warlock, recipes/websockify) and found it was in an excellent condition.

All these packages should use the standard python setup.py install
command.
@anguslees
Copy link
Author

I think that addresses the general comments raised so far - I'll split it up and we can discuss what to do about optional dependencies and any other recipe-level comments there.

@jakirkham
Copy link
Member

jakirkham commented May 4, 2016

Well, I would add the BSD license need to state how many clauses. For instance, BSD 2-Clause or BSD 3-Clause.

@jakirkham
Copy link
Member

Do these all work on Python 2.7, 3.4 and 3.5?

If some of the are Python 2 only, you should add skip: true # [py3k] to the build section. Alternatively, if some are Python 3 only, change py3k to py2k.

Patch pulled from http://bugs.python.org/issue24054 and trivially
backported, with these trivial changes:

- fix fuzz
- drop unnecessary "+ import tempfile" patch chunk
- also remove bad test input files that cause this issue - upstream did
  this outside the patch
Verified by inspection of the relevant archives.
@anguslees
Copy link
Author

Hrm. They all work with 2.7. At least websockify 0.6.1 doesn't work with py3. Newer versions of websockify do work with py3, but if I update it then I need to update lots of other things too (this is all old versions that I haven't updated in a while).

So: I feel like websockify 0.6 failing to build on py3 is maybe the desired result - some sort of test result dashboard should go red and indicate that we need to update it, and then after the update it will go green and we'll all be happy. ... Or should I just mark it as py2-only, and then we remember out-of-band to remove that selector when I/we get around to uploading newer versions?

@jakirkham
Copy link
Member

Or should I just mark it as py2-only, and then we remember out-of-band to remove that selector when I/we get around to uploading newer versions?

👍

@jakirkham
Copy link
Member

Just to point out something, these will all be separate repos. So issues of supporting previously unsupported platforms, Python versions, etc. can easily be tracked on those issue trackers.

We really don't want this repo (staged-recipes) to be the place where everything is perfected. This is more the place where things become good enough to be sent out to live on there own.

@jakirkham
Copy link
Member

Doing a little more clean up in PR ( anguslees#5 ). Also would you mind enabling the Allow edits from maintainers feature, @anguslees?

@anguslees
Copy link
Author

Maintainer edits allowed, thanks for the reminder.

Removes pluggy, retrying, and sqlalchemy-migrate
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/oslo.serialization, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/tox, recipes/websockify) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Thanks for doing that. Went ahead and merged that cleanup PR into here.

@jakirkham
Copy link
Member

Toggling for CIs

@jakirkham jakirkham closed this Oct 10, 2017
@jakirkham jakirkham reopened this Oct 10, 2017
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/oslo.serialization, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/tox, recipes/websockify) and found some lint.

Here's what I've got...

For recipes/oslo.serialization:

  • Feedstock with the same name exists in conda-forge

For recipes/tox:

  • Feedstock with the same name exists in conda-forge

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/websockify) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Toggling for CIs.

@jakirkham jakirkham closed this Dec 31, 2017
@jakirkham jakirkham reopened this Dec 31, 2017
@jakirkham
Copy link
Member

@conda-forge-admin, please relint.

Trying to get an accurate idea of which of these are still needed vs. those that are already packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/websockify) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/keystonemiddleware:

For recipes/nova:

For recipes/os-brick:

For recipes/oslo.concurrency:

For recipes/oslo.context:

For recipes/oslo.db:

For recipes/oslo.log:

For recipes/oslo.messaging:

For recipes/oslo.middleware:

For recipes/oslo.rootwrap:

For recipes/pycadf:

For recipes/python-cinderclient:

For recipes/python-glanceclient:

For recipes/python-keystoneclient:

For recipes/python-neutronclient:

For recipes/python-novaclient:

For recipes/python-subunit:

For recipes/testrepository:

For recipes/testresources:

For recipes/testscenarios:

For recipes/websockify:

@stale
Copy link

stale bot commented Feb 6, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 6, 2020
@stale stale bot removed the stale will be closed in 30 days label Feb 7, 2020
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.concurrency, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/pycadf, recipes/python-cinderclient, recipes/python-glanceclient, recipes/python-keystoneclient, recipes/python-neutronclient, recipes/python-novaclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/websockify) and found some lint.

Here's what I've got...

For recipes/keystonemiddleware:

  • license_file entry is missing, but is required.

For recipes/keystonemiddleware:

For recipes/nova:

  • license_file entry is missing, but is required.

For recipes/nova:

For recipes/os-brick:

  • license_file entry is missing, but is required.

For recipes/os-brick:

For recipes/oslo.concurrency:

  • license_file entry is missing, but is required.
  • Feedstock with the same name exists in conda-forge

For recipes/oslo.concurrency:

For recipes/oslo.context:

  • license_file entry is missing, but is required.

For recipes/oslo.context:

For recipes/oslo.db:

  • license_file entry is missing, but is required.

For recipes/oslo.db:

For recipes/oslo.log:

  • license_file entry is missing, but is required.

For recipes/oslo.log:

For recipes/oslo.messaging:

  • license_file entry is missing, but is required.

For recipes/oslo.messaging:

For recipes/oslo.middleware:

  • license_file entry is missing, but is required.

For recipes/oslo.middleware:

For recipes/oslo.rootwrap:

  • license_file entry is missing, but is required.

For recipes/oslo.rootwrap:

For recipes/pycadf:

  • license_file entry is missing, but is required.

For recipes/pycadf:

For recipes/python-cinderclient:

  • license_file entry is missing, but is required.
  • Feedstock with the same name exists in conda-forge

For recipes/python-cinderclient:

For recipes/python-glanceclient:

  • license_file entry is missing, but is required.
  • Feedstock with the same name exists in conda-forge

For recipes/python-glanceclient:

For recipes/python-keystoneclient:

  • license_file entry is missing, but is required.
  • Feedstock with the same name exists in conda-forge

For recipes/python-keystoneclient:

For recipes/python-neutronclient:

  • license_file entry is missing, but is required.

For recipes/python-neutronclient:

For recipes/python-novaclient:

  • license_file entry is missing, but is required.
  • Feedstock with the same name exists in conda-forge

For recipes/python-novaclient:

For recipes/python-subunit:

  • license_file entry is missing, but is required.

For recipes/python-subunit:

For recipes/testrepository:

  • license_file entry is missing, but is required.

For recipes/testrepository:

For recipes/testresources:

  • license_file entry is missing, but is required.

For recipes/testresources:

For recipes/testscenarios:

  • license_file entry is missing, but is required.

For recipes/testscenarios:

For recipes/websockify:

  • license_file entry is missing, but is required.

For recipes/websockify:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/keystonemiddleware, recipes/nova, recipes/os-brick, recipes/oslo.context, recipes/oslo.db, recipes/oslo.log, recipes/oslo.messaging, recipes/oslo.middleware, recipes/oslo.rootwrap, recipes/pycadf, recipes/python-neutronclient, recipes/python-subunit, recipes/testrepository, recipes/testresources, recipes/testscenarios, recipes/websockify) and found some lint.

Here's what I've got...

For recipes/keystonemiddleware:

  • license_file entry is missing, but is required.

For recipes/keystonemiddleware:

For recipes/nova:

  • license_file entry is missing, but is required.

For recipes/nova:

For recipes/os-brick:

  • license_file entry is missing, but is required.

For recipes/os-brick:

For recipes/oslo.context:

  • license_file entry is missing, but is required.

For recipes/oslo.context:

For recipes/oslo.db:

  • license_file entry is missing, but is required.

For recipes/oslo.db:

For recipes/oslo.log:

  • license_file entry is missing, but is required.

For recipes/oslo.log:

For recipes/oslo.messaging:

  • license_file entry is missing, but is required.

For recipes/oslo.messaging:

For recipes/oslo.middleware:

  • license_file entry is missing, but is required.

For recipes/oslo.middleware:

For recipes/oslo.rootwrap:

  • license_file entry is missing, but is required.

For recipes/oslo.rootwrap:

For recipes/pycadf:

  • license_file entry is missing, but is required.

For recipes/pycadf:

For recipes/python-neutronclient:

  • license_file entry is missing, but is required.

For recipes/python-neutronclient:

For recipes/python-subunit:

  • license_file entry is missing, but is required.

For recipes/python-subunit:

For recipes/testrepository:

  • license_file entry is missing, but is required.

For recipes/testrepository:

For recipes/testresources:

  • license_file entry is missing, but is required.

For recipes/testresources:

For recipes/testscenarios:

  • license_file entry is missing, but is required.

For recipes/testscenarios:

For recipes/websockify:

  • license_file entry is missing, but is required.

For recipes/websockify:

@beckermr beckermr added stale will be closed in 30 days and removed Awaiting author contribution labels May 27, 2020
@stale
Copy link

stale bot commented Jun 26, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

44 new feedstocks ...
7 participants