-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import recipes from github.com/anguslees/conda-* #537
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cliff:
For recipes/eventlet:
For recipes/kombu:
For recipes/nova:
For recipes/oslo.config:
For recipes/python-cinderclient:
For recipes/python-glanceclient:
For recipes/python-keystoneclient:
For recipes/python-neutronclient:
For recipes/python-novaclient:
For recipes/stevedore:
|
I piled everything into one PR because it was easier for me. Let me know if you would prefer one PR per recipe. |
As per conda-forge-linter's suggestion.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Breaking things up would be nice. You don't have to go all the way to one recipe per PR, but please limit it to related recipes in each PR. Otherwise, this will take forever to review, and might get lost. Thanks for adding your recipes! |
So, some of these already exist so let's start by clearing those out first. Feel free to PR the feedstocks and add yourself as a maintainer on them. |
I think I encouraged him to dump them in elsewhere. Though it's true. Review time is the biggest issue. |
Also, get rid of |
recipes/sqlalchemy-migrate/meta.yaml
Outdated
- six >=1.7.0 | ||
- decorator | ||
- sqlparse | ||
- tempita >-0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be >=0.4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, yes it should. None of the tools ever balked at that - I guess they were doing "greater than a negative number"?
Some general thoughts on the recipes.
|
Thanks for the submission, @anguslees. I have tried to make some general notes about things that we can leave out to make this PR a little more review friendly. There were also a few things that stood out that I commented on. From a brief skim, these appear to be pretty healthy recipes. |
Sorry, I thought I had removed the duplicates, but must have messed up my conda search command somehow. I'll try that process again now I have some candidates that should be detected.. I'll break it up into smaller chunks too.. |
No worries. I think those were the only ones. With the PR, it was named differently so not sure if you would have caught that.
Sure, but feel free to leave this here as you do. That way you can kind of keep a check list of what still needs to move. |
rabbitmq (#471) is rabbitmq-server, librabbitmq is a (python) client and not a duplicate, fwiw. |
Sorry, was doing my best to skim 160 files. 😜 |
amqp, kombu, vcversioner are already on conda-forge at equal or newer versions.
"tempita >-0.4" should have been ".. >=0.4"
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
All these packages should use the standard python setup.py install command.
I think that addresses the general comments raised so far - I'll split it up and we can discuss what to do about optional dependencies and any other recipe-level comments there. |
Well, I would add the BSD license need to state how many clauses. For instance, |
Do these all work on Python 2.7, 3.4 and 3.5? If some of the are Python 2 only, you should add |
Patch pulled from http://bugs.python.org/issue24054 and trivially backported, with these trivial changes: - fix fuzz - drop unnecessary "+ import tempfile" patch chunk - also remove bad test input files that cause this issue - upstream did this outside the patch
Verified by inspection of the relevant archives.
Hrm. They all work with 2.7. At least websockify 0.6.1 doesn't work with py3. Newer versions of websockify do work with py3, but if I update it then I need to update lots of other things too (this is all old versions that I haven't updated in a while). So: I feel like websockify 0.6 failing to build on py3 is maybe the desired result - some sort of test result dashboard should go red and indicate that we need to update it, and then after the update it will go green and we'll all be happy. ... Or should I just mark it as py2-only, and then we remember out-of-band to remove that selector when I/we get around to uploading newer versions? |
👍 |
Just to point out something, these will all be separate repos. So issues of supporting previously unsupported platforms, Python versions, etc. can easily be tracked on those issue trackers. We really don't want this repo (staged-recipes) to be the place where everything is perfected. This is more the place where things become good enough to be sent out to live on there own. |
Doing a little more clean up in PR ( anguslees#5 ). Also would you mind enabling the Allow edits from maintainers feature, @anguslees? |
Maintainer edits allowed, thanks for the reminder. |
Removes pluggy, retrying, and sqlalchemy-migrate
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for doing that. Went ahead and merged that cleanup PR into here. |
Toggling for CIs |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/oslo.serialization:
For recipes/tox:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Toggling for CIs. |
@conda-forge-admin, please relint. Trying to get an accurate idea of which of these are still needed vs. those that are already packaged. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/keystonemiddleware:
For recipes/nova:
For recipes/os-brick:
For recipes/oslo.concurrency:
For recipes/oslo.context:
For recipes/oslo.db:
For recipes/oslo.log:
For recipes/oslo.messaging:
For recipes/oslo.middleware:
For recipes/oslo.rootwrap:
For recipes/pycadf:
For recipes/python-cinderclient:
For recipes/python-glanceclient:
For recipes/python-keystoneclient:
For recipes/python-neutronclient:
For recipes/python-novaclient:
For recipes/python-subunit:
For recipes/testrepository:
For recipes/testresources:
For recipes/testscenarios:
For recipes/websockify:
|
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the Cheers and thank you for contributing to this community effort! |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/keystonemiddleware:
For recipes/keystonemiddleware:
For recipes/nova:
For recipes/nova:
For recipes/os-brick:
For recipes/os-brick:
For recipes/oslo.concurrency:
For recipes/oslo.concurrency:
For recipes/oslo.context:
For recipes/oslo.context:
For recipes/oslo.db:
For recipes/oslo.db:
For recipes/oslo.log:
For recipes/oslo.log:
For recipes/oslo.messaging:
For recipes/oslo.messaging:
For recipes/oslo.middleware:
For recipes/oslo.middleware:
For recipes/oslo.rootwrap:
For recipes/oslo.rootwrap:
For recipes/pycadf:
For recipes/pycadf:
For recipes/python-cinderclient:
For recipes/python-cinderclient:
For recipes/python-glanceclient:
For recipes/python-glanceclient:
For recipes/python-keystoneclient:
For recipes/python-keystoneclient:
For recipes/python-neutronclient:
For recipes/python-neutronclient:
For recipes/python-novaclient:
For recipes/python-novaclient:
For recipes/python-subunit:
For recipes/python-subunit:
For recipes/testrepository:
For recipes/testrepository:
For recipes/testresources:
For recipes/testresources:
For recipes/testscenarios:
For recipes/testscenarios:
For recipes/websockify:
For recipes/websockify:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/keystonemiddleware:
For recipes/keystonemiddleware:
For recipes/nova:
For recipes/nova:
For recipes/os-brick:
For recipes/os-brick:
For recipes/oslo.context:
For recipes/oslo.context:
For recipes/oslo.db:
For recipes/oslo.db:
For recipes/oslo.log:
For recipes/oslo.log:
For recipes/oslo.messaging:
For recipes/oslo.messaging:
For recipes/oslo.middleware:
For recipes/oslo.middleware:
For recipes/oslo.rootwrap:
For recipes/oslo.rootwrap:
For recipes/pycadf:
For recipes/pycadf:
For recipes/python-neutronclient:
For recipes/python-neutronclient:
For recipes/python-subunit:
For recipes/python-subunit:
For recipes/testrepository:
For recipes/testrepository:
For recipes/testresources:
For recipes/testresources:
For recipes/testscenarios:
For recipes/testscenarios:
For recipes/websockify:
For recipes/websockify:
|
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Closes conda-forge/conda-forge.github.io#8