Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mypy-boto3-sts #28918

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adding mypy-boto3-sts #28918

wants to merge 8 commits into from

Conversation

StevenSchaererQC
Copy link
Contributor

@StevenSchaererQC StevenSchaererQC commented Jan 24, 2025 •
edited
Loading

This is the same as #28917 but replacing mypy-boto3-kinesis with mypy-boto3-sts.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 24, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mypy-boto3-sts/recipe.yaml) and found it was in an excellent condition.

@StevenSchaererQC StevenSchaererQC marked this pull request as draft January 24, 2025 14:13
@StevenSchaererQC StevenSchaererQC marked this pull request as ready for review January 24, 2025 15:35
@StevenSchaererQC StevenSchaererQC marked this pull request as draft January 24, 2025 15:47
@StevenSchaererQC
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/mypy-boto3-sts/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: janjagusch. Please ask them to comment on this PR if they are.

@StevenSchaererQC
Copy link
Contributor Author

@janjagusch Can you please confirm whether you'd also be interested in maintaining this recipe?

@janjagusch
Copy link
Contributor

@janjagusch Can you please confirm whether you'd also be interested in maintaining this recipe?

Glad to be listed as a recipe maintainer here.

@StevenSchaererQC
Copy link
Contributor Author

@conda-forge-admin, please ping conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@StevenSchaererQC
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@StevenSchaererQC StevenSchaererQC marked this pull request as ready for review January 27, 2025 13:32
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@StevenSchaererQC StevenSchaererQC mentioned this pull request Jan 27, 2025
Open
10 tasks
synapticarbors
synapticarbors reviewed Jan 31, 2025
View reviewed changes
recipes/mypy-boto3-sts/recipe.yaml
python_version: ${{ python_min }}.*

about:
summary: Type annotations for boto3 STS ${{ version }}service generated with mypy-boto3-builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: Type annotations for boto3 STS ${{ version }}service generated with mypy-boto3-builder
summary: Type annotations for boto3 STS ${{ version }} service generated with mypy-boto3-builder

recipes/mypy-boto3-sts/recipe.yaml
version: ${{ version }}

source:
url: https://pypi.org/packages/source/${{ name[0] }}/${{ name }}/${{ name | replace('-', '_') }}-${{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://pypi.org/packages/source/${{ name[0] }}/${{ name }}/${{ name | replace('-', '_') }}-${{ version }}.tar.gz
url: https://pypi.org/packages/source/${{ name[0] }}/${{ name }}/mypy_boto3_sts-${{ version }}.tar.gz

recipes/mypy-boto3-sts/recipe.yaml
context:
name: mypy-boto3-sts
version: 1.36.0
python_min: "3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to set this if you're just using the conda-forge default of 3.9. I guess it's ok if you want to be explicit.

recipes/mypy-boto3-sts/recipe.yaml
noarch: python
script:
env:
PYTHONUTF8: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for setting this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synapticarbors synapticarbors synapticarbors left review comments

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StevenSchaererQC @conda-forge-admin @janjagusch @synapticarbors