Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ODL (Operator Discretization Library). #27504

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Adding ODL (Operator Discretization Library). #27504

merged 12 commits into from
Oct 10, 2024

Conversation

leftaroundabout
Copy link
Contributor

@leftaroundabout leftaroundabout commented Sep 6, 2024 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/odl/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [21, 37]
  • Recipe maintainer "Ozan Öktem (@ozanoktem)" does not exist
  • Recipe maintainer "Justus Sagemüller (@leftaroundabout)" does not exist
  • Recipe maintainer "Emilien Valat (@Emvlt)" does not exist
  • The following maintainers have not yet confirmed that they are willing to be listed here: Emilien Valat (@Emvlt), Justus Sagemüller (@leftaroundabout), Ozan Öktem (@ozanoktem). Please ask them to comment on this PR if they are.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/odl/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@Emvlt
Copy link

Emvlt commented Sep 6, 2024

I confirm that I agree to be listed as maintainer

1 similar comment
@leftaroundabout
Copy link
Contributor Author

I confirm that I agree to be listed as maintainer

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/odl/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ozanoktem. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/odl/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ozanoktem. Please ask them to comment on this PR if they are.

@ozanoktem
Copy link

I confirm that I agree to be listed as maintainer.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found it was in an excellent condition.

@leftaroundabout
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

@leftaroundabout leftaroundabout mentioned this pull request Sep 6, 2024
Open
@leftaroundabout
Copy link
Contributor Author

@conda-forge-admin, relint

@github-actions GitHub Actions
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

@github-actions GitHub Actions
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found it was in an excellent condition.

@leftaroundabout
Copy link
Contributor Author

@conda-forge/help-python, is there any problem that prevents this from being merged? It has been a while since I filed the pull request.

I already had some strange error reports, apparently because the recipe-branch had gone out of sync with the mainline. But after updating that, all checks pass again so I really don't see why the recipe couldn't be made into a feedstock.

xhochy
xhochy requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent with two spaces like all other recipes.

recipes/odl/meta.yaml Outdated Show resolved Hide resolved
recipes/odl/meta.yaml Outdated Show resolved Hide resolved
recipes/odl/meta.yaml Outdated Show resolved Hide resolved
recipes/odl/meta.yaml Show resolved Hide resolved
recipes/odl/meta.yaml Outdated Show resolved Hide resolved
@leftaroundabout
Add recipe for ODL (Operator Discretization Library).
175f754
@leftaroundabout
Satisfy Conda-Forge linter.
2bb056f
@leftaroundabout
Correct dependencies / bounds.
c864e06
@leftaroundabout
For some reason Conda-Forge does not want the Python version to be li…
fef0645 
…mited.

Versions older than 3.7 do not seem to be available from Conda anymore anyway (which
is why I have not tested them), so this should not really make a difference.
@leftaroundabout
Add real names of recipe maintainers.
472cb41 
This might be useful as information independent of Github.
@leftaroundabout
Use Jinja template syntax.
6cf601f
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/odl/meta.yaml:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [9, 9].

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found it was in an excellent condition.

@leftaroundabout
Reduce indentation.
5d607d3 
Apparently CondaForge uses only two spaces for each Yaml level.
@leftaroundabout
Remove apparently superfluous "host" requirements.
5d684f8 
I'm still not sure if I understand what this does exactly and why ODL specified
it, since a pure Python package should generally be host-invariant.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/odl/meta.yaml:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@leftaroundabout
Reinstore dependency bounds
ee00bfe 
These were removed in previous rounds of linter negotiations, but they are actually needed.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/odl/meta.yaml) and found it was in an excellent condition.

@leftaroundabout
Remove nomkl clause.
6f585a9 
This is apparently not needed anymore.
@leftaroundabout
Copy link
Contributor Author

@xhochy thanks. I have adopted all your suggestions, fixed problems in CI, and all the tests pass.

xhochy
xhochy requested changes Oct 6, 2024
View reviewed changes
recipes/odl/meta.yaml Show resolved Hide resolved
@leftaroundabout @xhochy
Add pip as a host dependency.
fbf2be9 
The build succeeds without that, but the `script` line does utilize pip so I suppose it is technically needed.

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@xhochy xhochy merged commit c2645a5 into conda-forge:main Oct 10, 2024
7 checks passed
@leftaroundabout
Copy link
Contributor Author

@xhochy great, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leftaroundabout @Emvlt @ozanoktem @conda-forge-admin @xhochy