Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for ragged #27281

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Add a recipe for ragged #27281

merged 9 commits into from
Aug 20, 2024

Conversation

hmaarrfk
Copy link
Contributor

Just fyi: cc: @conda-forge/awkward

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ragged/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ragged/recipe.yaml:

This is a rattler-build recipe and not yet lintable. We are working on it!

@hmaarrfk
Copy link
Contributor Author

@conda-forge/rattler-build is this noarch recipe correct? when i had numpy spcified, i had 3 conda files generated.

@hmaarrfk hmaarrfk marked this pull request as ready for review August 16, 2024 02:32
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ragged/meta.yaml) and found it was in an excellent condition.

@marcelotrevisani marcelotrevisani merged commit 0ebda74 into conda-forge:main Aug 20, 2024
5 checks passed
@wolfv
Copy link
Member

wolfv commented Aug 20, 2024

@hmaarrfk I filed an issue in rattler-build for the numpy-variant problem for noarch packages that you observed. I actually don't know how pins are taken into account for noarch packages...

@hmaarrfk
Copy link
Contributor Author

@hmaarrfk I filed an issue in rattler-build for the numpy-variant problem for noarch packages that you observed. I actually don't know how pins are taken into account for noarch packages...

wow you took a deep dive on my commit history! Thanks for that.

It was pretty cool to see rattler build things so fast!!!

@henryiii
Copy link
Contributor

Are there docs on using ratter-build with conda-forge, specifically on how to convert packages over? :)

@hmaarrfk
Copy link
Contributor Author

Are there docs on using ratter-build with conda-forge, specifically on how to convert packages over? :)

Not to my knoweldge. I used the recipe.yaml as sample syntax and went from ther.

@wolfv
Copy link
Member

wolfv commented Aug 21, 2024

We have some conversion tips here: https://prefix-dev.github.io/rattler-build/latest/converting_from_conda_build/

However, we still need a little bit of time to enable uploading the packages to the main conda-forge channel. Right now, a feedstock is created, but the upload is disallowed :)

The first feedstock that has the new recipe format is: https://github.com/conda-forge/jolt-physics-feedstock/ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants