-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding diffpy.srreal #25498
base: main
Are you sure you want to change the base?
Adding diffpy.srreal #25498
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
azure-pipelines.yml
Outdated
@@ -12,4 +12,3 @@ pr: | |||
jobs: | |||
- template: ./.azure-pipelines/azure-pipelines-linux.yml | |||
- template: ./.azure-pipelines/azure-pipelines-osx.yml | |||
- template: ./.azure-pipelines/azure-pipelines-win.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't touch these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I specify no build for windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the recipe:
build:
skip: true # [win]
recipes/diffpy.srreal/meta.yaml
Outdated
- libboost-python-devel | ||
|
||
run: | ||
- libdiffpy # NOTE libdiffpy is added implicitly from libdiffpy run_exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you shouldn't list it here.
recipes/diffpy.srreal/meta.yaml
Outdated
- python | ||
- setuptools | ||
- {{ pin_compatible('numpy', min_pin='x.x', max_pin='x') }} | ||
- libboost-python-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't depend on devel packages in run. The run_exports should be sufficient.
- libboost-python-devel |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
71c981f
to
e33b206
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal:
For recipes/diffpy.srreal:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/diffpy.srreal/meta.yaml:
|
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).