Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diffpy.srreal #25498

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

Sparks29032
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge. Please ask them to comment on this PR if they are.

For recipes/diffpy.srreal:

  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, XiaohaoYang, sbillinge. Please ask them to comment on this PR if they are.

For recipes/diffpy.srreal:

  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, XiaohaoYang, sbillinge. Please ask them to comment on this PR if they are.

For recipes/diffpy.srreal:

  • You should not need to depend on libboost-python directly. If your package is linking to libboost_python3x.so, use libboost-python-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.
  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, XiaohaoYang, sbillinge. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: XiaohaoYang, sbillinge, pavoljuhas. Please ask them to comment on this PR if they are.

@@ -12,4 +12,3 @@ pr:
jobs:
- template: ./.azure-pipelines/azure-pipelines-linux.yml
- template: ./.azure-pipelines/azure-pipelines-osx.yml
- template: ./.azure-pipelines/azure-pipelines-win.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't touch these files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I specify no build for windows?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the recipe:

build:
  skip: true  # [win]

- libboost-python-devel

run:
- libdiffpy # NOTE libdiffpy is added implicitly from libdiffpy run_exports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you shouldn't list it here.

- python
- setuptools
- {{ pin_compatible('numpy', min_pin='x.x', max_pin='x') }}
- libboost-python-devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't depend on devel packages in run. The run_exports should be sufficient.

Suggested change
- libboost-python-devel

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: sbillinge, XiaohaoYang, pavoljuhas. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: XiaohaoYang, sbillinge, pavoljuhas. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge, XiaohaoYang. Please ask them to comment on this PR if they are.

For recipes/diffpy.srreal:

  • The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge, XiaohaoYang. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge, XiaohaoYang. Please ask them to comment on this PR if they are.
  • pin_compatible should be used instead of pin_subpackage for libdiffpy because it is not a known output of this recipe: ['diffpy.srreal'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge, XiaohaoYang. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal:

  • The following maintainers have not yet confirmed that they are willing to be listed here: sbillinge, pavoljuhas, XiaohaoYang. Please ask them to comment on this PR if they are.

For recipes/diffpy.srreal:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/diffpy.srreal/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: XiaohaoYang, pavoljuhas, sbillinge. Please ask them to comment on this PR if they are.
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants