Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortmerna conda recipe #25438

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Sortmerna conda recipe #25438

wants to merge 17 commits into from

Conversation

biocodz
Copy link

@biocodz biocodz commented Feb 17, 2024

The current recipe will be maintained parallel to the Sortmerna bioconda-recipe. The bioconda recipe currently uses pre-built binaries. The current recipe performs the whole build including building 3rd party libraries. This recipe is also going to support Windows builds (not supported on bioconda).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sortmerna) and found some lint.

Here's what I've got...

For recipes/sortmerna:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14, 34]
  • license_file entry is missing, but is required.
  • The extra section contained an unexpected subsection name. skip-lints is not a valid subsection name.
  • The extra section contained an unexpected subsection name. identifiers is not a valid subsection name.

For recipes/sortmerna:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.
  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [9, 9, 9, 34, 35, 36].
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sortmerna) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sortmerna:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@bgruening
Copy link
Contributor

I don't think we should maintain the bioconda recipe in parallel. If this one is ready here we should remove the bioconda recipe.

@biocodz
Copy link
Author

biocodz commented Mar 7, 2024

I agree. Mentioned the parallel just for suggestions. How do we proceed with removing the bioconda recipe? Usual pull request?

@martin-g
Copy link

martin-g commented Apr 8, 2024

I was not aware of this PR.
I also worked on the Bioconda recipe to build packages for more platforms - bioconda/bioconda-recipes#46644
It is a duplicated work for now! Once this PR is merged I will create an Arch Migrator PR to add builds for linux-aarch64 and linux-ppc64le and another PR for dropping the Bioconda recipe!

@biocodz
Copy link
Author

biocodz commented Jun 19, 2024

Created bioconda-recipes PR 48607 to remove sortmerna recipe due relocation to conda-forge

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sortmerna) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sortmerna:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@biocodz
Copy link
Author

biocodz commented Jun 27, 2024

filed issue 5391 on conda-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants