Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich-click #18181

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Add rich-click #18181

merged 4 commits into from
Feb 28, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 28, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Thank you very much for putting in this recipe PR!

This repository is very active, so if you need help with
a PR or once it's ready for review, please let the right people know.
There are language-specific teams for reviewing recipes.

Currently available teams are:

  • python @conda-forge/help-python
  • python/c hybrid @conda-forge/help-python-c
  • r @conda-forge/help-r
  • java @conda-forge/help-java
  • nodejs @conda-forge/help-nodejs
  • c/c++ @conda-forge/help-c-cpp
  • perl @conda-forge/help-perl
  • Julia @conda-forge/help-julia
  • ruby @conda-forge/help-ruby

If your PR doesn't fall into those categories please contact
the full review team @conda-forge/staged-recipes.

Due to GitHub limitations first time contributors to conda-forge are unable
to ping these teams. You can ping the team using a special command in
a comment on the PR to get the attention of the staged-recipes team. You can
also consider asking on our Gitter channel if your recipe isn't reviewed promptly.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rich-click) and found it was in an excellent condition.

@ewels
Copy link
Member Author

ewels commented Feb 28, 2022

Ready for review @conda-forge/help-python 🙏🏻

@saraedum
Copy link
Member

saraedum commented Feb 28, 2022

Should this package be noarch: python, i.e., is there a reason we need to build a separate version of this for every OS and architecture? See https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#architecture-independent-packages

@ewels
Copy link
Member Author

ewels commented Feb 28, 2022

For the noarch thing, I left it because there is a PR for rich-click likely to be merged imminently which will add a console_script.

I was reading the conda-forge docs about it which made me nervous so I thought maybe I should play it safe and leave it out. Specifically:

Scripts argument in setup.py is not used

Re-reading this I see the following line though:

If console_scripts entry_points are defined in setup.py or setup.cfg, they are also listed in the build section of meta.yaml

Which I guess covers this use case. I'm not entirely sure what it means by listing in the build section, but I guess I can look into that again when I have a release with the console_script stuff included.

Set an upper-limit to the requirements to protect against future breaking changes.

Co-authored-by: Julian Rüth <julian.rueth@fsfe.org>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rich-click) and found some lint.

Here's what I've got...

For recipes/rich-click:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

recipes/rich-click/meta.yaml Outdated Show resolved Hide resolved
recipes/rich-click/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rich-click) and found it was in an excellent condition.

@saraedum
Copy link
Member

Yes, I would imagine that your use case is covered. You'd just need to add a line like this to the build section: https://github.com/conda-forge/svgdigitizer-feedstock/blob/master/recipe/meta.yaml#L13

@ewels
Copy link
Member Author

ewels commented Feb 28, 2022

Ah, many thanks for the reference @saraedum - super helpful ⭐

@saraedum saraedum merged commit 3580af8 into conda-forge:main Feb 28, 2022
@saraedum
Copy link
Member

Thanks for your contribution @ewels. I am looking forward to trying out rich-click in some of my Python packages.

@ewels ewels deleted the rich-click branch February 28, 2022 19:23
@ewels
Copy link
Member Author

ewels commented Feb 28, 2022

Thanks for the quick and helpful review @saraedum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants