-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rich-click
#18181
Add rich-click
#18181
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ready for review @conda-forge/help-python 🙏🏻 |
Should this package be |
For the I was reading the conda-forge docs about it which made me nervous so I thought maybe I should play it safe and leave it out. Specifically:
Re-reading this I see the following line though:
Which I guess covers this use case. I'm not entirely sure what it means by listing in the build section, but I guess I can look into that again when I have a release with the console_script stuff included. |
Set an upper-limit to the requirements to protect against future breaking changes. Co-authored-by: Julian Rüth <julian.rueth@fsfe.org>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/rich-click:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Yes, I would imagine that your use case is covered. You'd just need to add a line like this to the build section: https://github.com/conda-forge/svgdigitizer-feedstock/blob/master/recipe/meta.yaml#L13 |
Ah, many thanks for the reference @saraedum - super helpful ⭐ |
Thanks for your contribution @ewels. I am looking forward to trying out rich-click in some of my Python packages. |
Thanks for the quick and helpful review @saraedum! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).Thank you very much for putting in this recipe PR!
This repository is very active, so if you need help with
a PR or once it's ready for review, please let the right people know.
There are language-specific teams for reviewing recipes.
Currently available teams are:
@conda-forge/help-python
@conda-forge/help-python-c
@conda-forge/help-r
@conda-forge/help-java
@conda-forge/help-nodejs
@conda-forge/help-c-cpp
@conda-forge/help-perl
@conda-forge/help-julia
@conda-forge/help-ruby
If your PR doesn't fall into those categories please contact
the full review team
@conda-forge/staged-recipes
.Due to GitHub limitations first time contributors to conda-forge are unable
to ping these teams. You can ping the team using a special command in
a comment on the PR to get the attention of the
staged-recipes
team. You canalso consider asking on our Gitter channel if your recipe isn't reviewed promptly.