Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perspective package #10884

Merged
merged 4 commits into from
Jun 7, 2020
Merged

Add perspective package #10884

merged 4 commits into from
Jun 7, 2020

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 18, 2020 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found some lint.

Here's what I've got...

For recipes/perspective:

  • requirements: host: pyarrow==0.15.1 must contain a space between the name and the pin, i.e. pyarrow ==0.15.1
  • requirements: run: ipywidgets>=7.5.1 must contain a space between the name and the pin, i.e. ipywidgets >=7.5.1
  • requirements: run: numpy>=1.13.1 must contain a space between the name and the pin, i.e. numpy >=1.13.1
  • requirements: run: pandas>=0.22.0 must contain a space between the name and the pin, i.e. pandas >=0.22.0
  • requirements: run: pyarrow==0.15.1 must contain a space between the name and the pin, i.e. pyarrow ==0.15.1
  • requirements: run: python-dateutil>=2.8.0 must contain a space between the name and the pin, i.e. python-dateutil >=2.8.0
  • requirements: run: six>=1.11.0 must contain a space between the name and the pin, i.e. six >=1.11.0
  • requirements: run: traitlets>=4.3.2 must contain a space between the name and the pin, i.e. traitlets >=4.3.2

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found some lint.

Here's what I've got...

For recipes/perspective:

  • requirements: host: numpy >= 1.13.1 should not contain a space between relational operator and the version, i.e. numpy >=1.13.1
  • requirements: host: pyarrow == 0.15.1 should not contain a space between relational operator and the version, i.e. pyarrow ==0.15.1
  • requirements: run: ipywidgets >= 7.5.1 should not contain a space between relational operator and the version, i.e. ipywidgets >=7.5.1
  • requirements: run: numpy >= 1.13.1 should not contain a space between relational operator and the version, i.e. numpy >=1.13.1
  • requirements: run: python-dateutil >= 2.8.0 should not contain a space between relational operator and the version, i.e. python-dateutil >=2.8.0
  • requirements: run: six >= 1.11.0 should not contain a space between relational operator and the version, i.e. six >=1.11.0
  • requirements: run: traitlets >= 4.3.2 should not contain a space between relational operator and the version, i.e. traitlets >=4.3.2

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

@texodus @neilslinger please confirm you want to be listed as maintainer

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found some lint.

Here's what I've got...

For recipes/perspective:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

finos/perspective#930 for license

@timkpaine
Copy link
Member Author

finos/perspective#927 to remove yarn and pass tests

@timkpaine
Copy link
Member Author

thanks @marcelotrevisani ! just waiting on a few PRs, @texodus is getting around to them this week. then i'll bump the version and we'll be good to go

@timkpaine timkpaine mentioned this pull request Feb 23, 2020
Closed
@texodus
Copy link
Member

texodus commented Feb 24, 2020

I am a maintainer and want to be listed.

Like that?

@neilslinger
Copy link

Yes - please list me as a maintainer too

@timkpaine
Copy link
Member Author

0.4.4 will remove the need for npm or yarn, has better VS/VC support (defaults to VC14.1/VS2017, with support for VC14/VS2015) and will bundle the LICENSE, which should clear up the tests. I will bump this recipe when the release is done.

@texodus texodus mentioned this pull request Mar 4, 2020
Closed
@timkpaine
Add perspective
1af667f 
fix yml lint

fix yml lint

Add neil

fix lint

path to license, wrong name for pybind

typo

typo

Update recipes/perspective/meta.yaml

Co-Authored-By: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>

Update recipes/perspective/meta.yaml

Co-Authored-By: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>

Bump version, test imports

update sha
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found some lint.

Here's what I've got...

For recipes/perspective:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/perspective) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

@conda-forge/help-python all set for now

@marcelotrevisani marcelotrevisani merged commit ad079d7 into conda-forge:master Jun 7, 2020
@timkpaine timkpaine deleted the perspective branch September 5, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceball ceball ceball left review comments

@marcelotrevisani marcelotrevisani marcelotrevisani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timkpaine @conda-forge-linter @texodus @neilslinger @ceball @marcelotrevisani