Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for librabbitmq #1012

Merged
merged 9 commits into from
Nov 6, 2016
Merged

Added recipe for librabbitmq #1012

merged 9 commits into from
Nov 6, 2016

Conversation

pmlandwehr
Copy link
Contributor

Pinging @ask in case they'd like to be added as a maintainer to the librabbitmq builder on conda-forge, a library of community-built conda packages. The maintenance burden here is light: all testing and releases are built and deployed automatically with CI. Changes to how the package is being built can be controlled by changing the recipe which will be located at https://github.com/conda-forge/librabbitmq-feedstock shortly after this PR is finished and merged. If you aren't interested in helping maintain the build, that's entirely fine too.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/librabbitmq) and found some lint.

Here's what I've got...

For recipes/librabbitmq:

  • The recipe could do with some maintainers listed in the "extra/recipe-maintainers" section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/librabbitmq) and found it was in an excellent condition.

@pmlandwehr
Copy link
Contributor Author

I can probably just kill import funtests, but I'd be curious to know why it only fails on 2.7 for windows. Any insights?

@patricksnape
Copy link
Contributor

Well it's only running for Python 2.7 right? So it's just failing on Windows. As to why that is - I'm not sure.

@patricksnape
Copy link
Contributor

I think this is your issue - Windows unsupported?

@pmlandwehr
Copy link
Contributor Author

Ha! Perfect. I'll kill windows for now.


extra:
recipe-maintainers:
- pmlandwehr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any interest in helping maintain, @anguslees?

jakirkham added a commit to jakirkham/staged-recipes that referenced this pull request Sep 19, 2016
@jakirkham jakirkham merged commit a2076a1 into conda-forge:master Nov 6, 2016
@jakirkham
Copy link
Member

Thanks @pmlandwehr .

As the CI is really stale, I'm hoping it still passes. 🍀 However, I guess we will find out at the feedstock.

@pmlandwehr pmlandwehr deleted the librabbitmq branch January 27, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants