Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump to 10.3 #39

Merged
merged 6 commits into from
Jun 20, 2024
Merged

MAINT: Bump to 10.3 #39

merged 6 commits into from
Jun 20, 2024

Conversation

larsoner
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As with conda-forge/pyobjc-framework-coreservices-feedstock#20, no idea why this one didn't auto-tick. Opening for 10.3 and locally ran conda-smithy rerender -c auto. I suggest to merge this then I'll make a follow-up PR to bump to 10.3.1.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hoechenberger
Copy link
Member

New project URL is https://github.com/ronaldoussoren/pyobjc

In case you feel like updating that

recipe/meta.yaml Outdated

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 3a75f38bb1d5d2cf6a0d3e92801b3510f32e96cf6443d81b9dd92a84d72eff0a
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name|lower }}-{{ version }}.tar.gz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is a relevant change -- the previous releases had pyobjc-framework-FSEvents in the sdist name but 10.3 and 10.3.1 sdists have pyobjc-framework-fsevents. All wheels have the capitalized version, and other packages like pyobjc-framework-coreservices kept caps in the sdist name, so it's probably a bug that the sdist is not capitalized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... argh, and underscores

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That probably explains why the bot didn't pick up on the new release

@hoechenberger hoechenberger merged commit 85afec9 into conda-forge:main Jun 20, 2024
11 checks passed
@hoechenberger
Copy link
Member

Great!

@larsoner larsoner deleted the bump branch June 20, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants