Fix OpenJDK to v8 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Looks good to me! |
|
Maybe we need to include the JVM version in the package name/make separate packages for each JVM version. After all, pyjnius built against jvm8 might not be compatible with jvm9. |
|
That's a good point. I think Conda has a mechanism for this (similar to what they do with Numpy) but I don't know enough... Maybe @jakirkham could comment? In the meantime, @hanslovsky can you merge this and I will open an issue about JVM version. |
|
See #4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kivy/pyjnius#304 needs to be fixed to use OpenJDK >8
Ping @hanslovsky