Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add olefile #26

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Add olefile #26

merged 1 commit into from
Jan 27, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 25, 2017

Closes #25

Needs conda-forge/olefile-feedstock#3 on Python 3.6

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

@djhoese
Copy link

djhoese commented Jan 26, 2017

@ocefpaf Any idea why these builds are failing?

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 26, 2017

Like I said above:

Needs conda-forge/olefile-feedstock#3 on Python 3.6

and that one completed a few hours ago. (Travis-CI is awfully slow these days 😒)

I am re-starting the CIs and it should pass.

@djhoese
Copy link

djhoese commented Jan 26, 2017

Ah I saw that the olefile had completed and that the travis jobs had restarted earlier today. Thought it was something else. Sorry to bother. Thanks for the help.

@ocefpaf ocefpaf merged commit 2dd4b1b into conda-forge:master Jan 27, 2017
@ocefpaf ocefpaf deleted the olefile branch January 27, 2017 17:19
@djhoese
Copy link

djhoese commented Jan 27, 2017

@ocefpaf Would it be possible to remove the 4.0.0_0 package on the conda-forge channel? Since you rerendered in this PR there is now only a broken version of pillow left for python 3.4.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 27, 2017

We don't really remove broken packages, long story... But I will move it to the broken channel.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 27, 2017

Actually, now that I think about it, the package is only missing olefile at run time. So it is probably OK to leave that version there and let users install olefile manually. Better that than nothing for Python 3.4 users out there.

@djhoese
Copy link

djhoese commented Jan 27, 2017

Well there are still the older versions of pillow, but ok I'll have to add olefile to my packages requirements until we can officially bump python versions.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 27, 2017

Well there are still the older versions of pillow, but ok I'll have to add olefile to my packages requirements until we can officially bump python versions.

If I remove that you will get an older version of pillow on Python 3.4. At least you have a choice 😄 4.0 but force install olefile or pillow < 4 😉

@djhoese
Copy link

djhoese commented Jan 27, 2017

Alright alright, you got me. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants