Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lingering --debug flag #10

Merged
merged 1 commit into from
May 23, 2016
Merged

Drop lingering --debug flag #10

merged 1 commit into from
May 23, 2016

Conversation

jakirkham
Copy link
Member

Oops, this crept in somehow. Amazingly it didn't seem to affect the *NIXes, but maybe it broke Windows more? Let's see if this improves the situation.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented May 23, 2016

Indeed that is weird that the debug mode passed everywhere but Windows. Things seems to be back to normal in AppVeyor.

@jakirkham
Copy link
Member Author

Doesn't magically fix 32-bit Python 3.4, but it doesn't seem to break the other builds.

@jakirkham
Copy link
Member Author

I spoke too soon Python 3.5 on Windows is now failing. 😳

Though I think we are now hitting this issue ( conda-forge/staged-recipes#666 ).

@jakirkham jakirkham merged commit 10e0e50 into conda-forge:master May 23, 2016
@jakirkham jakirkham deleted the drop_lingering_debug_flag branch May 23, 2016 22:54
@jakirkham
Copy link
Member Author

Merged as this is making the situation less bad. Though there is still a larger problem with Python 3.5 Windows builds ( conda-forge/staged-recipes#666 ) and the same Python 3.4 32-bit Windows failure as before ( #9 ).

@ocefpaf
Copy link
Member

ocefpaf commented May 23, 2016

Merged as this is making the situation less bad. Though there is still a larger problem with Python 3.5 Windows builds ( conda-forge/staged-recipes#666 ) and the same Python 3.4 32-bit Windows failure as before ( #9 ).

What a Monday! I could not get a single package to compile as well 😬

@jakirkham
Copy link
Member Author

I know. Between the GitHub issues, subsequent CI issues, and now this nonsense, I was debating just call it a day.

Though I'm pretty happy that we got something done with Pillow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants