Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 10 #35

Merged
merged 15 commits into from
Nov 22, 2018
Merged

Java 10 #35

merged 15 commits into from
Nov 22, 2018

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 20, 2018

DO NOT MERGE: need #34 to be merged first.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The "requirements" section was expected to be a dictionary, but got a NoneType.
  • The "requirements" section was expected to be a dictionary, but got a NoneType.
  • The test section contained an unexpected subsection name. requirements is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sodre
Copy link
Member

sodre commented Nov 22, 2018

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sodre
Copy link
Member

sodre commented Nov 22, 2018

@conda-forge-admin, please rerender.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sodre
Copy link
Member

sodre commented Nov 22, 2018

@conda-forge-admin, please rerender

recipe/meta.yaml Outdated Show resolved Hide resolved
@sodre
Copy link
Member

sodre commented Nov 22, 2018

@hadim, would you mind incorporating fixes for #37 and #38 before merging this back into the master branch?

Also, I noticed that other folders are now available in the Java Distribution, for example the conf folder, can you make sure if that is needed and if so, where it should be placed.

Thanks so much for refreshing this recipe!

@hadim
Copy link
Member Author

hadim commented Nov 22, 2018

Will do.

@hadim
Copy link
Member Author

hadim commented Nov 22, 2018

Ready for review/merge @sodre

@sodre sodre merged commit 0a80c31 into conda-forge:master Nov 22, 2018
@hadim hadim deleted the java10 branch November 22, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants