Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package doesnt work with newer versions of arrow #9

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

kmod
Copy link
Contributor

@kmod kmod commented Mar 8, 2022

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • license_file entry is missing, but is required.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 8, 2022

Thanks for the heads-up: this may have been my second or third recipe, and needs some general updates to get out the door, will do so on another branch.

By the by: is there an issue somewhere that documents that this is the correct version, or did you have to bisect it?

@bollwyvl bollwyvl merged commit 2f94e97 into conda-forge:master Mar 8, 2022
@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 8, 2022

Thanks, this was merged as part of #10, should be good to go in a couple hours.

@kmod
Copy link
Contributor Author

kmod commented Mar 8, 2022

Ah sorry I've had this sitting around for a while and I don't remember exactly. I think what happened was there was some sort of error due to an API changing, and I googled it and found a site that mentioned that API change and the version it happened in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants