-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for 2024.5.0 #24
Update dependencies for 2024.5.0 #24
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.05.17.03.43.53
This comment was marked as resolved.
This comment was marked as resolved.
3b78c87
to
d5b4b9d
Compare
d5b4b9d
to
67f2b53
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Marking as draft until we confirm what we would like to do upstream: dask/dask-image#374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed slicerator
and scikit-image
from the dependencies, as per the discussion in dask/dask-image#374
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Ok, the conda-forge docker build does not pass because dask-image v2024.05.0 says it requires scikit-image and slicerator (those dependencies we think should be removed, and were removed in dask/dask-image#374) . I assume the best thing to do now is to tag v2024.5.1 on dask-image, and see if that fixes things over here. |
Sounds good As |
We can also do a release, but I'd be ok punting on that for now and just trying Edit: Expect CI will pass |
Honestly it's probably easier to do that now. I don't think I'm going to remember to check the dask-image-feedstock issues at the right time just before the next release. All we have to do is add a v2024.5.1 tag to dask-image, right? |
Yep that would work It would be a good test of the Grayskull dependency update bits we just added here 😉 |
Ok, I'll do that now 😄 |
Thanks Genevieve! 🙏 Am wondering if that will also fix the doc versioning issue we saw |
Here we go: https://github.com/dask/dask-image/releases/tag/v2024.5.1
I don't think so, but that docs hypothesis is just my best guess for now. |
pip check
in tests to confirm thisAlso submitted a couple minor tweaks upstream: dask/dask-image#374
Fixes #25