Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for 2024.5.0 #24

Merged

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented May 17, 2024

  • Update dependencies to match latest release
  • Add pip check in tests to confirm this
  • Enable Grayskull for version updates to automate dependency handling

Also submitted a couple minor tweaks upstream: dask/dask-image#374

Fixes #25

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices

This comment was marked as resolved.

@jakirkham jakirkham force-pushed the conda_forge_admin_23 branch from 3b78c87 to d5b4b9d Compare May 17, 2024 07:55
@jakirkham jakirkham force-pushed the conda_forge_admin_23 branch from d5b4b9d to 67f2b53 Compare May 17, 2024 07:55
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham changed the title MNT: rerender Update decencies for 2024.5.0 May 17, 2024
@jakirkham jakirkham changed the title Update decencies for 2024.5.0 Update dependencies for 2024.5.0 May 17, 2024
@jakirkham jakirkham marked this pull request as draft May 17, 2024 17:51
@jakirkham
Copy link
Member

Marking as draft until we confirm what we would like to do upstream: dask/dask-image#374

@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review May 21, 2024 04:06
@jakirkham jakirkham added the automerge Merge the PR when CI passes label May 21, 2024
Copy link
Contributor

@GenevieveBuckley GenevieveBuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed slicerator and scikit-image from the dependencies, as per the discussion in dask/dask-image#374

Copy link
Contributor

github-actions bot commented May 21, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham removed the automerge Merge the PR when CI passes label May 21, 2024
recipe/meta.yaml Outdated Show resolved Hide resolved
@GenevieveBuckley
Copy link
Contributor

Ok, the conda-forge docker build does not pass because dask-image v2024.05.0 says it requires scikit-image and slicerator (those dependencies we think should be removed, and were removed in dask/dask-image#374) .

I assume the best thing to do now is to tag v2024.5.1 on dask-image, and see if that fixes things over here.

@jakirkham
Copy link
Member

Sounds good

As pip check will fail due to those dependencies not being included, have commented and raised issue ( #26 ) to remind us to reenable it next release

@jakirkham
Copy link
Member

jakirkham commented May 21, 2024

We can also do a release, but I'd be ok punting on that for now and just trying pip check later

Edit: Expect CI will pass

@jakirkham jakirkham added the automerge Merge the PR when CI passes label May 21, 2024
@github-actions github-actions bot merged commit 56048d5 into conda-forge:main May 21, 2024
3 checks passed
@GenevieveBuckley
Copy link
Contributor

We can also do a release, but I'd be ok punting on that for now and just trying pip check later

Honestly it's probably easier to do that now. I don't think I'm going to remember to check the dask-image-feedstock issues at the right time just before the next release.

All we have to do is add a v2024.5.1 tag to dask-image, right?

@jakirkham
Copy link
Member

Yep that would work

It would be a good test of the Grayskull dependency update bits we just added here 😉

@GenevieveBuckley
Copy link
Contributor

Ok, I'll do that now 😄

@jakirkham
Copy link
Member

Thanks Genevieve! 🙏

Am wondering if that will also fix the doc versioning issue we saw

@GenevieveBuckley
Copy link
Contributor

Here we go: https://github.com/dask/dask-image/releases/tag/v2024.5.1

Am wondering if that will also fix the doc versioning issue we saw

I don't think so, but that docs hypothesis is just my best guess for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing setuptools_scm is causing incorrect metadata
3 participants