Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libgcc.so symlink in sysroot #112

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jul 22, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf added the automerge Merge the PR when CI passes label Jul 22, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jul 22, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk
Copy link
Contributor

is this still necessary? all red.

@isuruf
Copy link
Member Author

isuruf commented Sep 10, 2023

Yes, need to fix this for clang.

@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

(local rerender seemed to hang; no progress after ~20+ min)

@h-vetinari
Copy link
Member

Rerender is broken, removed.

@hmaarrfk
Copy link
Contributor

I remember that rerendering this takes about 40 mins ;)

tmux + go do something else!

@beckermr
Copy link
Member

I did see a bug in smithy where you have to rerender twice and it alternates between a good one and a bad if I remember correctly. I never tracked it down. That might have been for this feedstock. I am not sure.

The CHOST-variant only gets created in install-gcc.sh, so pull that forward
@h-vetinari
Copy link
Member

@isuruf, I may have fixed this now. 🙃

@isuruf
Copy link
Member Author

isuruf commented Nov 2, 2023

Thanks

@isuruf isuruf added the automerge Merge the PR when CI passes label Nov 2, 2023
@h-vetinari
Copy link
Member

So the cross-compiled s390x targets are failing with

libtool: install: warning: relinking `libasan.la'
libtool: install: ...
libtool: relink: ...
collect2: fatal error: ld terminated with signal 9 [Killed]

but the native s390x compilers passed, so this should sort itself out upon restart I guess...

IMO we should merge and see (not least given the lack of usage of s390x compilers) - WDYT?

@h-vetinari h-vetinari merged commit a798457 into conda-forge:main Nov 2, 2023
40 of 50 checks passed
@isuruf
Copy link
Member Author

isuruf commented Nov 2, 2023

Come on. What's the hurry? You are not even a maintainer of this repository.

@isuruf
Copy link
Member Author

isuruf commented Nov 2, 2023

I'm removing this commit and resending the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants