feat: add hint for new noarch: python syntax #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
@conda-forge/core this one is ready for review! |
jaimergp
reviewed
Nov 5, 2024
| def hint_noarch_python_use_python_min( | ||
| host_reqs, run_reqs, test_reqs, outputs_section, noarch_value, hints | ||
| ): | ||
| if noarch_value == "python" and not outputs_section: |
There was a problem hiding this comment.
We don't hint multi output recipes? 🤔
There was a problem hiding this comment.
Not currently no. IDK why.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it is out of scope for this PR given that it is already in the code base.
jaimergp
reviewed
Nov 5, 2024
jaimergp
approved these changes
Nov 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)This PR adds hints for the new
noarch: pythonsyntax. They are not lints since this syntax is not required per the CFEP.