handle source.url as list in pypi.org linter rule #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bollwyvl
changed the title
|
@conda-forge/conda-smithy ready for review |
beckermr
approved these changes
Nov 1, 2024
|
Thanks! |
|
Thank you! I just released smithy with the fix. |
3 tasks
|
BTW, that change should probably be included in a piggy back migration and/or a rerender to make it easier to spread the change across all feedstocks. I've been away from smithy and the bot's code for a while but I can give it a go next week if no one beats me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new linter rule (while great) doesn't take into account that a
source.urlcan be a list of URLs (with fallback).This is an issue for e.g.
selenium, where the upstream git tag (bleargh) can be one of either:4.26.0python-4.26.1Checklist
newsentrypython conda_smithy/schema.py)