Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrator for portaudio 19.7 #6633

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 31, 2024

We do not have any pin for portaudio, even if it is a package that contains a shared library with a run_exports (see https://github.com/conda-forge/portaudio-feedstock/blob/f44a5cdbd074197009f575b2c73b575ba558c90e/recipe/meta.yaml#L17) and it is a dependency of several packages across conda-forge (https://github.com/search?q=org%3Aconda-forge+portaudio+language%3AYAML&type=code).

As done for example in #3931, first I add a migrator for portaudio 19.7 to ensure that all feedstocks use the latest portaudio, and then I intend to add a pin for portaudio once the migrator is done.

Fix conda-forge/portaudio-feedstock#23 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from a team as a code owner October 31, 2024 11:50
@traversaro
Copy link
Contributor Author

traversaro commented Oct 31, 2024

fyi @conda-forge/portaudio @ryanvolz

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

commit_message: Rebuild for portaudio 19.7
kind: version
migration_number: 1
libmatio:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a copy paste leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for noticing! Fixed.

@hmaarrfk hmaarrfk merged commit c354e4f into conda-forge:main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add portaudio 19.7.0 migrator and then add portaudio to pinning
4 participants