Skip to content

Does one need to check that the ABI changed from X to Y. #3368

Open

Description

Comment:

I find the the question:

- [ ]  I checked that the ABI changed from X to Y.

doesn't really explain to the user what should happen if the ABI didn't change.

The challenge is two fold:

  1. The bot is kinda an "easy solution". It is also the "safe" solution.
  2. Patching requires more manual (error prone) work that simply click merge on the bot rebuild.

So really, I would like to propose some clarification on what should happen if the pin doesn't change. I find "rebuilding" to be a good solution, even if the ABI doesn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions