Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use sed in _tc_activation #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manopapad
Copy link

@manopapad manopapad commented Aug 29, 2022

Checklist

The clang activation script causes conda activation to take ~5s on my Mac laptop, which is quite annoying for those of us who want to conda activate on shell startup. The reason for this is that sed is called in a loop in _tc_activation, to split a string at the first occurrence of a comma, and sed seems to be quite slow on Mac. However, there is no reason to use sed for this; substring-substitution is a fast and portable way to achieve the same effect.

This change doesn't apply to just this repo's recipe, it could be copied onto every activation script that uses _tc_activation, but I couldn't easily find a good place to make this change globally.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@manopapad
Copy link
Author

@conda-forge-admin, please rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants