Bump to 986 / 711 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
davidbrochart,
isuruf,
katietz and
mingwandroid
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
commented
Oct 12, 2023
Comment on lines
22
to
25
| # Taken from https://github.com/tpoechtrager/cctools-port/pull/116 | ||
| - patches/0003-Restore-using-__builtin_available-for-macos.patch | ||
| # Taken from https://github.com/tpoechtrager/cctools-port/pull/118 | ||
| - patches/0004-Turn-off-outputIsMappableFile-when-building-to-osx-a.patch |
There was a problem hiding this comment.
Sidenote: There's some (belated) upstream review comments for both of these PRs.
|
Gentle ping @conda-forge/cctools-and-ld64 CC @xhochy |
|
Looks good but we're not really testing these in the test? Did you try them downstream somewhere? |
Didn't set up the feedstock, just maintaining it as far as necessary for the LLVM stack... Last update wasn't tested more than this either...
No |
|
@isuruf, thoughts on this? |
|
Thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that tpoechtrager/cctools-port#134 was closed, let's try updating!
Separated from #62 to avoid interference between different update processes.