Fix index initialization and loop termination condition of LockFreePool's remove method - #44
Merged
Conversation
Member
|
Yes, from looking at the code, that looks like a correct analysis and the right fix as far as I can see. Thank you for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm reading your book these days (thanks for your interesting book) , and I ran into the error below while I was running
LockFreePoolexample.I think the reason is because the existing implementation incorrectly terminates the loop without checking the bucket at the starting index (
start). So, I fixed it by modifying the loop todo-whilefromwhileand initializingiwithstartinstead of(start + 1) % buckets.length. It will ensure that the bucket at the starting index is also considered during the scan.