add answers to exercise 1-4 chapter 6 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * Implement a custom Observable[Thread] object that emits an event when it detects that a thread was started. | ||
| * The implementation is allowed to miss some of the events. |
There was a problem hiding this comment.
Maybe the problem statement is not super-precise in the book, but the intention was to detect when any thread whatsoever in that JVM process was started, not just one specific thread.
There was a problem hiding this comment.
Just to expand on my previous comment a bit:
Note that the problem statement says that you can miss some of the events. This is because JVM does not have a callback API for creation and starting of new threads. It means that you will have to periodically poll to find out which threads that exist in the runtime, and emit events when you observe differences.
|
Thanks @axel22 |
|
Thank you for the PR! :) |
|
Hi @axel22 , |
axel22
added a commit
that referenced
this pull request
Jan 11, 2016
add answers to exercise 1-4 chapter 6
|
LGTM - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @axel22
Pls see this answers